fix(oembed): uri withQuery does only accept strings

Dominik Jansen · Dominik Jansen · commit f4314f681875 · 2020-10-29T09:36:00.000+01:00
diff --git a/src/Adapters/Facebook/OEmbed.php b/src/Adapters/Facebook/OEmbed.php
@@ -26,7 +26,7 @@ protected function detectEndpoint(): ?UriInterface
 
         return $this->extractor->getCrawler()
             ->createUri($this->getEndpointByPath($uri->getPath()))
-            ->withQuery($queryParameters);
+            ->withQuery(http_build_query($queryParameters));
     }
 
     private function getEndpointByPath(string $path): string
diff --git a/src/Adapters/Instagram/OEmbed.php b/src/Adapters/Instagram/OEmbed.php
@@ -24,6 +24,6 @@ protected function detectEndpoint(): ?UriInterface
 
         return $this->extractor->getCrawler()
             ->createUri(self::ENDPOINT)
-            ->withQuery($queryParameters);
+            ->withQuery(http_build_query($queryParameters));
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ protected function detectEndpoint(): ?UriInterface`
`26`	`26`
`27`	`27`	`return $this->extractor->getCrawler()`
`28`	`28`	`->createUri($this->getEndpointByPath($uri->getPath()))`
`29`		`- ->withQuery($queryParameters);`
	`29`	`+ ->withQuery(http_build_query($queryParameters));`
`30`	`30`	`}`
`31`	`31`
`32`	`32`	`private function getEndpointByPath(string $path): string`
Original file line number	Diff line number	Diff line change
`@@ -24,6 +24,6 @@ protected function detectEndpoint(): ?UriInterface`
`24`	`24`
`25`	`25`	`return $this->extractor->getCrawler()`
`26`	`26`	`->createUri(self::ENDPOINT)`
`27`		`- ->withQuery($queryParameters);`
	`27`	`+ ->withQuery(http_build_query($queryParameters));`
`28`	`28`	`}`
`29`	`29`	`}`