tests improvements

Author: oscarotero

src/Adapters/Google.php

@@ -30,7 +30,7 @@ public function getCode()
         $url = $this->request->createUrl()
             ->withDirectoryPosition(3, 'preview')
             ->withQueryParameters([]);
-        
+
         return Utils::iframe($url);
 
         //this code of google maps no longer works

src/Embed.php

@@ -11,7 +11,10 @@ class Embed
      * @param string|Request $request The url or a request with the url
      * @param array          $config  Options passed to the adapter
      *
-     * @return false|AdapterInterface
+     * @throws Exceptions\InvalidUrlException If the urls is not valid
+     * @throws \InvalidArgumentException      If any config argument is not valid
+     *
+     * @return AdapterInterface
      */
     public static function create($request, array $config = array())
     {

tests/AnimotoTest.php

@@ -3,7 +3,7 @@ class AnimotoTest extends TestCaseBase
 {
     public function testOne()
     {
-        $info = Embed\Embed::create('https://animoto.com/play/JzwsBn5FRVxS0qoqcBP5zA');
+        $info = $this->getInfo('https://animoto.com/play/JzwsBn5FRVxS0qoqcBP5zA');
 
         $this->assertString($info->title, 'Juno Groove');
         $this->assertString($info->width, 640);

tests/AolTest.php

@@ -3,7 +3,7 @@ class AolTest extends TestCaseBase
 {
     public function testOne()
     {
-        $info = Embed\Embed::create('http://on.aol.com/video/whats-next-for-google-in-two-minutes-518288612');
+        $info = $this->getInfo('http://on.aol.com/video/whats-next-for-google-in-two-minutes-518288612');
 
         $this->assertString($info->title, "What's Next for Google in Two Minutes");
         $this->assertString($info->description, "Wherein we smoosh Google's 2014 developer conference keynote from 2.5+ hours down to just under two minutes.");

tests/AppTest.php

@@ -3,7 +3,7 @@ class AppTest extends TestCaseBase
 {
     public function testOne()
     {
-        $info = Embed\Embed::create('https://alpha.app.net/chrifpa/post/33532003/photo/1');
+        $info = $this->getInfo('https://alpha.app.net/chrifpa/post/33532003/photo/1');
 
         $this->assertString($info->title, "Image_from_Riposte_2014-06-28.jpg");
         $this->assertString($info->description, 'is what I see in my mind when I hear “there’s now a $foo in javascript”. This [photos.app.net]');

tests/ArchiveTest.php

@@ -3,7 +3,7 @@ class ArchiveTest extends TestCaseBase
 {
     public function testOne()
     {
-        $info = Embed\Embed::create('https://archive.org/details/dn2015-0220_vid');
+        $info = $this->getInfo('https://archive.org/details/dn2015-0220_vid');
 
         $this->assertString($info->width, 640);
         $this->assertString($info->height, 480);

tests/BambuserTest.php

@@ -3,7 +3,7 @@ class BambuserTest extends TestCaseBase
 {
     public function testOne()
     {
-        $info = Embed\Embed::create('http://bambuser.com/v/4740575');
+        $info = $this->getInfo('http://bambuser.com/v/4740575');
 
         $this->assertString($info->title, "#OccupyWestminster #SaveILF #London #olsx  #ONN");
         $this->assertString($info->description, 'Broadcast by dancole on Bambuser.com');

tests/BandcampTest.php

@@ -3,7 +3,7 @@ class BandcampTest extends TestCaseBase
 {
     public function testOne()
     {
-        $info = Embed\Embed::create('http://jeanjean.bandcamp.com/track/coquin-l-l-phant');
+        $info = $this->getInfo('http://jeanjean.bandcamp.com/track/coquin-l-l-phant');
 
         $this->assertString($info->title, "Coquin L'éléphant, by Jean Jean");
         $this->assertString($info->description, 'from the album Symmetry');

tests/BlipTest.php

@@ -3,7 +3,7 @@ class BlipTest extends TestCaseBase
 {
     public function testOne()
     {
-        $info = Embed\Embed::create('http://blip.tv/indevelopment/iamsorry-6839170');
+        $info = $this->getInfo('http://blip.tv/indevelopment/iamsorry-6839170');
 
         $this->assertString($info->title, '#IAMSORRY');
         $this->assertString($info->imageWidth, 720);

tests/ChirbitTest.php

@@ -3,7 +3,7 @@ class ChirbitTest extends TestCaseBase
 {
     public function testOne()
     {
-        $info = Embed\Embed::create('http://chirb.it/7A9L9B');
+        $info = $this->getInfo('http://chirb.it/7A9L9B');
 
         $this->assertString($info->title, 'Chirbit [nvanderklippe] Encana conference call');
         $this->assertString($info->width, 398);