Respect port numbers in buildUrl()

dman-coders · dman-coders · commit c4156ec592cc · 2016-04-28T17:14:33.000+12:00
BuildUrl() does not support the full list of URL parts that parse_url() provided. 
Need to at least support port numbers (issue found when running automated testing in a sandbox, where the scraper target was on not-port-80)
diff --git a/src/Url.php b/src/Url.php
@@ -419,6 +419,10 @@ protected function buildUrl()
             $url .= $this->info['host'];
         }
 
+        if (isset($this->info['port'])) {
+            $url .= ':' . $this->info['port'];
+        }
+
         $url .= $this->getPath();
 
         if (!empty($this->info['query'])) {

Original file line number	Diff line number	Diff line change
`@@ -419,6 +419,10 @@ protected function buildUrl()`
`419`	`419`	`$url .= $this->info['host'];`
`420`	`420`	`}`
`421`	`421`
	`422`	`+ if (isset($this->info['port'])) {`
	`423`	`+ $url .= ':' . $this->info['port'];`
	`424`	`+ }`
	`425`	`+`
`422`	`426`	`$url .= $this->getPath();`
`423`	`427`
`424`	`428`	`if (!empty($this->info['query'])) {`