fixed accept header for images #275

Author: oscarotero

src/Http/CurlDispatcher.php

@@ -12,6 +12,12 @@
 class CurlDispatcher implements DispatcherInterface
 {
     private $responses = [];
+    private static $acceptHeaders = [
+        'jpg' => 'image/jpeg',
+        'jpeg' => 'image/jpeg',
+        'gif' => 'image/gif',
+        'png' => 'image/png',
+    ];
 
     private $config = [
         CURLOPT_MAXREDIRS => 10,
@@ -79,7 +85,14 @@ public function __destruct()
     public function dispatch(Url $url)
     {
         $options = $this->config;
-        $options[CURLOPT_HTTPHEADER] = ['Accept: text/html'];
+
+        $extension = $url->getExtension();
+
+        if (!empty($extension) && isset(self::$acceptHeaders[$extension])) {
+            $options[CURLOPT_HTTPHEADER] = ['Accept: '.self::$acceptHeaders[$extension]];
+        } else {
+            $options[CURLOPT_HTTPHEADER] = ['Accept: text/html'];
+        }
 
         $response = $this->exec($url, $options);
 
@@ -176,7 +189,10 @@ public function dispatchImages(array $urls)
 
             $connection = curl_init((string) $url);
 
-            curl_setopt_array($connection, $this->config);
+            $options = $this->config;
+            $options[CURLOPT_HTTPHEADER] = ['Accept: image/*'];
+
+            curl_setopt_array($connection, $options);
             curl_multi_add_handle($curl_multi, $connection);
 
             $curl = new CurlResult($connection);

tests/ImageInfoTest.php

@@ -13,15 +13,15 @@ public function testCurl()
         $dispatcher = new CurlDispatcher();
 
         $result = $dispatcher->dispatchImages([
-            Url::create('http://www.mixdecultura.ro/wp-content/uploads/2013/03/galicia-locuinte-celtice.jpg'),
+            Url::create('https://lightwitch.org/Media/Default/Pictures/server_station.jpg'),
         ]);
 
         $this->assertCount(1, $result);
 
         $img = $result[0];
 
-        $this->assertEquals(600, $img->getWidth());
-        $this->assertEquals(408, $img->getHeight());
+        $this->assertEquals(5504, $img->getWidth());
+        $this->assertEquals(3096, $img->getHeight());
         $this->assertEquals('image/jpeg', $img->getContentType());
     }