security fixes

oscarotero · oscarotero · commit 673cc5b4cef7 · 2021-09-22T21:57:44.000+02:00
diff --git a/src/OEmbed.php b/src/OEmbed.php
@@ -136,6 +136,8 @@ private static function isXML(UriInterface $uri): bool
     private function extractXML(string $xml): array
     {
         try {
+            // Remove the DOCTYPE declaration for to prevent XML Quadratic Blowup vulnerability
+            $xml = preg_replace('/^<!DOCTYPE[^>]*+>/i', '', $xml, 1);
             $data = [];
             $errors = libxml_use_internal_errors(true);
             $content = new SimpleXMLElement($xml);
diff --git a/tests/fixtures/i.imgur.com.x6rkcc5.jpg.php b/tests/fixtures/i.imgur.com.x6rkcc5.jpg.php
@@ -15,7 +15,7 @@
     'favicon' => 'https://i.imgur.com/favicon.ico',
     'feeds' => [],
     'icon' => null,
-    'image' => 'http://i.imgur.com/X6rkCc5.jpg',
+    'image' => 'https://i.imgur.com/X6rkCc5.jpg',
     'keywords' => [],
     'language' => null,
     'languages' => [],

Original file line number	Diff line number	Diff line change
`@@ -136,6 +136,8 @@ private static function isXML(UriInterface $uri): bool`
`136`	`136`	`private function extractXML(string $xml): array`
`137`	`137`	`{`
`138`	`138`	`try {`
	`139`	`+ // Remove the DOCTYPE declaration for to prevent XML Quadratic Blowup vulnerability`
	`140`	`+ $xml = preg_replace('/^<!DOCTYPE[^>]*+>/i', '', $xml, 1);`
`139`	`141`	`$data = [];`
`140`	`142`	`$errors = libxml_use_internal_errors(true);`
`141`	`143`	`$content = new SimpleXMLElement($xml);`