Skip to content

Commit 5b18996

Browse files
committed
fixed tests, updated changelog
1 parent 5c402fc commit 5b18996

File tree

3 files changed

+15
-4
lines changed

3 files changed

+15
-4
lines changed

CHANGELOG.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,14 @@ All notable changes to this project will be documented in this file.
55
The format is based on [Keep a Changelog](http://keepachangelog.com/)
66
and this project adheres to [Semantic Versioning](http://semver.org/).
77

8+
## [4.3.5] - Unreleased
9+
### Fixed
10+
- Updated oEmbed endpoints
11+
- Fixed embed code for Instagram [#456], [#459]
12+
13+
### Security
14+
- Fixed a possible XML Quadratic Blowup vulnerability.
15+
816
## [4.3.4] - 2021-06-22
917
### Fixed
1018
- Urls of images should include the same url for the `$info->image` value. [#452]
@@ -145,7 +153,10 @@ Full library refactoring.
145153
[#450]: https://github.com/oscarotero/Embed/issues/450
146154
[#451]: https://github.com/oscarotero/Embed/issues/451
147155
[#452]: https://github.com/oscarotero/Embed/issues/452
156+
[#456]: https://github.com/oscarotero/Embed/issues/456
157+
[#459]: https://github.com/oscarotero/Embed/issues/459
148158

159+
[4.3.5]: https://github.com/oscarotero/Embed/compare/v4.3.4...HEAD
149160
[4.3.4]: https://github.com/oscarotero/Embed/compare/v4.3.3...v4.3.4
150161
[4.3.3]: https://github.com/oscarotero/Embed/compare/v4.3.2...v4.3.3
151162
[4.3.2]: https://github.com/oscarotero/Embed/compare/v4.3.1...v4.3.2

src/Adapters/Instagram/OEmbed.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ protected function detectEndpoint(): ?UriInterface
2222
if (strpos($uri->getPath(), 'login') !== false) {
2323
$uri = $this->extractor->getRequest()->getUri();
2424
}
25-
25+
2626
$queryParameters = $this->getOembedQueryParameters((string) $uri);
2727
$queryParameters['access_token'] = $token;
2828

tests/fixtures/open.spotify.com.album-7s66wu1xj2nsuuwm2nkiuv.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
'cms' => null,
88
'code' => [
99
'html' => '<iframe width="100%" height="380" title="Spotify Embed: A Cantar con Xabarin (Vol. I &amp; II)" frameborder="0" allowfullscreen allow="autoplay; clipboard-write; encrypted-media; fullscreen; picture-in-picture" src="https://open.spotify.com/embed/album/7s66wU1XJ2NsUuWM2NKiUV"></iframe>',
10-
'width' => 300,
10+
'width' => 456,
1111
'height' => 380,
1212
'ratio' => 83.333
1313
],
@@ -770,8 +770,8 @@
770770
]
771771
],
772772
'oEmbed' => [
773-
'html' => '<iframe width="300" height="380" allowtransparency="true" frameborder="0" allow="encrypted-media" title="Spotify Embed: A Cantar con Xabarin (Vol. I &amp; II)" src="https://open.spotify.com/embed/album/7s66wU1XJ2NsUuWM2NKiUV"></iframe>',
774-
'width' => 300,
773+
'html' => '<iframe width="100%" height="380" title="Spotify Embed: A Cantar con Xabarin (Vol. I &amp; II)" frameborder="0" allowfullscreen allow="autoplay; clipboard-write; encrypted-media; fullscreen; picture-in-picture" src="https://open.spotify.com/embed/album/7s66wU1XJ2NsUuWM2NKiUV"></iframe>',
774+
'width' => 456,
775775
'height' => 380,
776776
'version' => '1.0',
777777
'provider_name' => 'Spotify',

0 commit comments

Comments
 (0)