Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributing - Image and Video #101

Open
SheepIsGoat opened this issue Sep 15, 2024 · 1 comment
Open

Contributing - Image and Video #101

SheepIsGoat opened this issue Sep 15, 2024 · 1 comment

Comments

@SheepIsGoat
Copy link

Hey there, I'd like to contribute to the images and video feature. Do you have guidelines for contributing, or any pre-existing scoping or opinions on how you'd like those implemented?

@SheepIsGoat
Copy link
Author

SheepIsGoat commented Sep 15, 2024

Separate comment, it looks like the where filters are already based on unindexed full collections scans. In the part where you're doing text matching with operations and string maps, have you considered adding a sister function that instead just takes a
map[string] func (string) bool so users could define their own more complex logic? Would let us support string contains, string not contains, regex, etc. I'd be happy to draft up an PR to show my thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant