Use Clipboard API instead of execCommand("Paste")

Author: NI57721

content_scripts/hud.js

@@ -36,6 +36,9 @@ const HUD = {
       this.hudUI.toggleIframeElementClasses("vimiumUIComponentHidden", "vimiumUIComponentVisible");
       // Force the re-computation of styles, so Chrome sends a visibility change message to the child frame.
       // See https://github.com/philc/vimium/pull/3277#issuecomment-487363284
+
+      // Allow to access the clipboard through iframes.
+      this.hudUI.iframeElement.allow = "clipboard-read";
       getComputedStyle(this.hudUI.iframeElement).display;
     } else {
       this.hudUI.toggleIframeElementClasses("vimiumClickable", "vimiumNonClickable");

lib/clipboard.js

@@ -20,12 +20,11 @@ const Clipboard = {
   },
 
   // Returns a string representing the clipboard contents. Supports rich text clipboard values.
-  paste() {
+  async paste() {
     const textArea = this._createTextArea("div"); // Use a <div> so Firefox pastes rich text.
     document.body.appendChild(textArea);
     textArea.focus();
-    document.execCommand("Paste");
-    const value = textArea.innerText;
+    const value = await navigator.clipboard.readText();
     document.body.removeChild(textArea);
     // When copying &nbsp; characters, they get converted to \xa0. Convert to space instead. See #2217.
     return value.replace(/\xa0/g, " ");

pages/hud.js

@@ -153,9 +153,9 @@ const handlers = {
   },
 
   pasteFromClipboard() {
-    Utils.setTimeout(TIME_TO_WAIT_FOR_IPC_MESSAGES, function() {
+    Utils.setTimeout(TIME_TO_WAIT_FOR_IPC_MESSAGES, async function() {
       const focusedElement = document.activeElement;
-      const data = Clipboard.paste();
+      const data = await Clipboard.paste();
       if (focusedElement != null)
         focusedElement.focus();
       window.parent.focus();