Skip to content

Commit 7a9fc8d

Browse files
gdh1995philc
authored andcommitted
Vomnibar: fix a bug preventing ctrl-enter from working
Chrome may assign `"\n"` as the `key` property of an `Enter` key, which made `Ctrl+Enter` not work as expected.
1 parent e10d269 commit 7a9fc8d

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

lib/keyboard_utils.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@ Utils.monitorChromeStorage("mapKeyRegistry", (value) => { return mapKeyRegistry
44
const KeyboardUtils = {
55
// This maps event.key key names to Vimium key names.
66
keyNames: {
7-
"ArrowLeft": "left", "ArrowUp": "up", "ArrowRight": "right", "ArrowDown": "down", " ": "space"
7+
"ArrowLeft": "left", "ArrowUp": "up", "ArrowRight": "right", "ArrowDown": "down", " ": "space",
8+
"\n": "enter" // on a keypress event of Ctrl+Enter, tested on Chrome 92 and Windows 10
89
},
910

1011
init() {

pages/vomnibar.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ class VomnibarUI {
160160
} else if ((key === "down") ||
161161
(event.ctrlKey && ((key === "j") || (key === "n")))) {
162162
return "down";
163-
} else if (event.ctrlKey && (event.key === "Enter")) {
163+
} else if (event.ctrlKey && (key === "enter")) {
164164
return "ctrl-enter";
165165
} else if (event.key === "Enter") {
166166
return "enter";

0 commit comments

Comments
 (0)