Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP binary name #115

Open
PgBiel opened this issue Jan 28, 2025 · 4 comments
Open

LSP binary name #115

PgBiel opened this issue Jan 28, 2025 · 4 comments

Comments

@PgBiel
Copy link
Contributor

PgBiel commented Jan 28, 2025

Taking a look at AineeJames/c3-zed#1, it seems that there is an inconsistency in how extensions expect the LSP binary to be named. We currently have releases named as c3lsp, but the Zed extension expects c3-lsp and Nixpkgs exports c3-lsp as well, which I assume is due to the repository name. Should we change and standardize the binary name as c3-lsp? Perhaps we could provide both as separate zips for this release as a temporary workaround, and eventually transition into a single option (be it with or without the dash) after discussing with downstream.

@MaxBeaud
Copy link

MaxBeaud commented Feb 5, 2025

I've noticed this as well and in the bash install/update script I wrote it simply creates a symlink. Not ideal but hey.

@pherrymason
Copy link
Owner

The Nix package was setup by @tomaskallup

You can see here it references to the old name of the binary: https://github.com/tomaskallup/c3-lsp/blob/main/flake.nix

@tomaskallup, maybe you could update the name?

@pherrymason
Copy link
Owner

pherrymason commented Feb 5, 2025

Just to clarify, I consciously changed the binary name to c3lsp (I removed the dash in the filename). I felt like it was unnecessary.

The commit was here: 593ab9c#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52

@tomaskallup
Copy link

My fork has a simple flake for building from source and also uses c3-lps. I've changed mine to be c3lsp and I'll try to PR into nixpgs, so it can get updated to the new name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants