-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LSP binary name #115
Comments
I've noticed this as well and in the bash install/update script I wrote it simply creates a symlink. Not ideal but hey. |
The Nix package was setup by @tomaskallup You can see here it references to the old name of the binary: https://github.com/tomaskallup/c3-lsp/blob/main/flake.nix @tomaskallup, maybe you could update the name? |
Just to clarify, I consciously changed the binary name to The commit was here: 593ab9c#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52 |
My fork has a simple flake for building from source and also uses |
Taking a look at AineeJames/c3-zed#1, it seems that there is an inconsistency in how extensions expect the LSP binary to be named. We currently have releases named as
c3lsp
, but the Zed extension expectsc3-lsp
and Nixpkgs exportsc3-lsp
as well, which I assume is due to the repository name. Should we change and standardize the binary name asc3-lsp
? Perhaps we could provide both as separate zips for this release as a temporary workaround, and eventually transition into a single option (be it with or without the dash) after discussing with downstream.The text was updated successfully, but these errors were encountered: