Skip to content

Commit c42f710

Browse files
committed
fix: keyboard shortcuts and removed unavailable menu items
1 parent d3d1005 commit c42f710

File tree

3 files changed

+20
-11
lines changed

3 files changed

+20
-11
lines changed

src/base-config/keyboard.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,21 @@
11
{
2-
"file.newDoc": [
3-
"Ctrl-N"
2+
"file.newFile": [
3+
"Alt-N"
44
],
55
"file.open": [
66
"Ctrl-O"
77
],
88
"file.close": [
9-
"Ctrl-W"
9+
"Alt-W"
1010
],
1111
"file.openFolder": [
1212
"Ctrl-Alt-O"
1313
],
1414
"file.close_all": [
15-
"Ctrl-Shift-W"
15+
"Alt-Shift-W"
1616
],
1717
"file.save": [
18-
"Ctrl-s"
18+
"Ctrl-S"
1919
],
2020
"file.saveAll": [
2121
"Ctrl-Alt-S"

src/command/DefaultMenus.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -74,12 +74,12 @@ define(function (require, exports, module) {
7474
menu.addMenuDivider();
7575
menu.addMenuItem(Commands.FILE_SAVE);
7676
menu.addMenuItem(Commands.FILE_SAVE_ALL);
77-
menu.addMenuItem(Commands.FILE_SAVE_AS);
77+
// menu.addMenuItem(Commands.FILE_SAVE_AS); not yet available in phoenix
7878
menu.addMenuDivider();
79-
//menu.addMenuItem(Commands.TOGGLE_LIVE_PREVIEW_MB_MODE);
80-
menu.addMenuItem(Commands.FILE_PROJECT_SETTINGS);
81-
menu.addMenuDivider();
82-
menu.addMenuItem(Commands.FILE_EXTENSION_MANAGER);
79+
//menu.addMenuItem(Commands.TOGGLE_LIVE_PREVIEW_MB_MODE); remove this mode as its not in phcode
80+
// menu.addMenuItem(Commands.FILE_PROJECT_SETTINGS); not yet available in phoenix
81+
//menu.addMenuDivider(); not yet available in phoenix
82+
// menu.addMenuItem(Commands.FILE_EXTENSION_MANAGER); not yet available in phoenix
8383

8484
/*
8585
* Edit menu

src/command/KeyBindingManager.js

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -511,7 +511,16 @@ define(function (require, exports, module) {
511511
key = "Insert";
512512
} else if (event.keyCode === KeyEvent.DOM_VK_DELETE) {
513513
key = "Delete";
514-
} else {
514+
} else if (key === "ArrowUp") {
515+
key = "Up";
516+
} else if (key === "ArrowDown") {
517+
key = "Down";
518+
} else if (key === "ArrowLeft") {
519+
key = "Left";
520+
} else if (key === "ArrowRight") {
521+
key = "Right";
522+
}
523+
else {
515524
key = _mapKeycodeToKey(event.keyCode, key);
516525
}
517526

0 commit comments

Comments
 (0)