feat: change publish icon to share icon

abose · abose · commit 1326f8014297 · 2022-03-14T22:34:08.000+05:30
diff --git a/src/extensions/default/Phoenix/images/globe2.svg b/src/extensions/default/Phoenix/images/globe2.svg
diff --git a/src/extensions/default/Phoenix/images/share-fill.svg b/src/extensions/default/Phoenix/images/share-fill.svg
@@ -0,0 +1,3 @@
+<svg xmlns="http://www.w3.org/2000/svg" fill="currentColor" class="bi bi-share-fill" viewBox="0 0 24 24">
+  <path transform="translate(3 4)" fill="#d6d7d7" d="M11 2.5a2.5 2.5 0 1 1 .603 1.628l-6.718 3.12a2.499 2.499 0 0 1 0 1.504l6.718 3.12a2.5 2.5 0 1 1-.488.876l-6.718-3.12a2.5 2.5 0 1 1 0-3.256l6.718-3.12A2.5 2.5 0 0 1 11 2.5z"/>
+</svg>
diff --git a/src/extensions/default/Phoenix/serverSync.js b/src/extensions/default/Phoenix/serverSync.js
@@ -211,10 +211,10 @@ define(function (require, exports, module) {
         }
         Dialogs.showModalDialog(
             DefaultDialogs.DIALOG_ID_INFO,
-            "Publish website?",
+            "Publish and Share website?",
             `Quickly preview changes and share your website with others. Phoenix can publish this website for you at 
              <a href="${_getProjectPreviewURL()}">${_getProjectPreviewURL()}</a>.
-             The files you edit and save will be instantly published. Do you wish to publish your website?`,
+             The files you edit and save will be instantly published. Do you wish to publish and share your website?`,
             [
                 {
                     className: Dialogs.DIALOG_BTN_CLASS_NORMAL,
@@ -282,7 +282,7 @@ define(function (require, exports, module) {
                 id: syncButtonID,
                 href: "#",
                 class: "preview",
-                title: "Click to publish site."
+                title: "Click to publish and share this site."
             })
             .appendTo($("#main-toolbar .buttons"));
         $icon.on('click', ()=>{
@@ -296,7 +296,8 @@ define(function (require, exports, module) {
     }
 
     setInterval(()=>{
-        // periodically check
+        // periodically check if the preview tab is manually closed by user. We do this by light polling as
+        // we cannot attach an onTabClosed event to the tab.
         if(previewInProgress && (!tab || tab.closed)){
             previewInProgress = false;
         }
diff --git a/src/extensions/default/Phoenix/styles.css b/src/extensions/default/Phoenix/styles.css
@@ -8,5 +8,5 @@
 }
 
 .preview {
-    background-image: url("./images/globe2.svg");
+    background-image: url("./images/share-fill.svg");
 }

Original file line number	Diff line number	Diff line change
`@@ -211,10 +211,10 @@ define(function (require, exports, module) {`
`211`	`211`	`}`
`212`	`212`	`Dialogs.showModalDialog(`
`213`	`213`	`DefaultDialogs.DIALOG_ID_INFO,`
`214`		`- "Publish website?",`
	`214`	`+ "Publish and Share website?",`
`215`	`215`	`Quickly preview changes and share your website with others. Phoenix can publish this website for you at
`216`	`216`	`<a href="${_getProjectPreviewURL()}">${_getProjectPreviewURL()}</a>.`
`217`		- The files you edit and save will be instantly published. Do you wish to publish your website?`,
	`217`	+ The files you edit and save will be instantly published. Do you wish to publish and share your website?`,
`218`	`218`	`[`
`219`	`219`	`{`
`220`	`220`	`className: Dialogs.DIALOG_BTN_CLASS_NORMAL,`
`@@ -282,7 +282,7 @@ define(function (require, exports, module) {`
`282`	`282`	`id: syncButtonID,`
`283`	`283`	`href: "#",`
`284`	`284`	`class: "preview",`
`285`		`- title: "Click to publish site."`
	`285`	`+ title: "Click to publish and share this site."`
`286`	`286`	`})`
`287`	`287`	`.appendTo($("#main-toolbar .buttons"));`
`288`	`288`	`$icon.on('click', ()=>{`
`@@ -296,7 +296,8 @@ define(function (require, exports, module) {`
`296`	`296`	`}`
`297`	`297`
`298`	`298`	`setInterval(()=>{`
`299`		`- // periodically check`
	`299`	`+ // periodically check if the preview tab is manually closed by user. We do this by light polling as`
	`300`	`+ // we cannot attach an onTabClosed event to the tab.`
`300`	`301`	`if(previewInProgress && (!tab \|\| tab.closed)){`
`301`	`302`	`previewInProgress = false;`
`302`	`303`	`}`
Original file line number	Diff line number	Diff line change
`@@ -8,5 +8,5 @@`
`8`	`8`	`}`
`9`	`9`
`10`	`10`	`.preview {`
`11`		`- background-image: url("./images/globe2.svg");`
	`11`	`+ background-image: url("./images/share-fill.svg");`
`12`	`12`	`}`