Skip to content

Commit 5af0b7b

Browse files
authored
Merge pull request #236 from pharmaverse/221-swap-in-lintrlibrary_call_linter
Closes #221
2 parents 89d3dd1 + 35c9404 commit 5af0b7b

File tree

7 files changed

+8
-92
lines changed

7 files changed

+8
-92
lines changed

DESCRIPTION

+1-1
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ Suggests:
6565
pkgdown,
6666
Tplyr,
6767
haven,
68-
lintr,
68+
lintr (>= 3.1.1),
6969
xml2,
7070
here,
7171
readr,

NEWS.md

+4
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
# logrx 0.3.3
2+
3+
- Swap in `lintr::library_call_linter()` for local version of `library_call_linter()` (#221)
4+
15
# logrx 0.3.2
26

37
- Hotfix to update tests (#231)

R/library_call_linter.R

-88
This file was deleted.

tests/testthat/Rplots.pdf

0 Bytes
Binary file not shown.

tests/testthat/test-get.R

+1-1
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ test_that("library lint returns expected result when multiple linters are set",
172172
skip_if_not_installed("xml2")
173173

174174
options("log.rx" = NULL)
175-
withr::local_options(log.rx.lint = c(library_call_linter(), lintr::undesirable_operator_linter()))
175+
withr::local_options(log.rx.lint = c(lintr::library_call_linter(), lintr::undesirable_operator_linter()))
176176
filename <- test_path("ref", "ex7.R")
177177

178178
# get is called within log_config

tests/testthat/test-writer.R

+1-1
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,7 @@ test_that("write_lint_results works when linter is used but no lints found", {
223223

224224
options("log.rx" = NULL)
225225
log_config(filename)
226-
lint_results <- lintr::lint(filename, c(library_call_linter()))
226+
lint_results <- lintr::lint(filename, c(lintr::library_call_linter()))
227227
assign('lint_results', lint_results, envir = getOption('log.rx'))
228228

229229
expect_identical(

vignettes/options.Rmd

+1-1
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ If you or your organization would like to implement any linters, you can set you
5151

5252
<br>
5353

54-
It is recommended to use the `library_call_linter()`. This is to ensure `logrx` will find the correct package and functions used.
54+
It is recommended to use the `lintr::library_call_linter()`. This is to ensure `logrx` will find the correct package and functions used.
5555

5656
<br>
5757

0 commit comments

Comments
 (0)