fix: check if .gnuplot is up-to-date in a more reliable way

Fixes #1397

Signed-off-by: Yukai Chou <[email protected]>

Author: muzimuzhi

doc/generic/pgf/CHANGELOG.md

@@ -22,6 +22,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 - Treat varargs for `min()` and `max()` in `luamath` pgf library pgf-tikz/pgfplots#492 #1359
 - Fixed support for the `\tikz` command in the `dvisvgm4ht` driver for TeX4ht
 - Wrong key name in unknown decoration option error #1082
+- `gnuplot` is always run when the function contains leading or trailing spaces #1397
 
 ### Changed
 

tex/generic/pgf/frontendlayer/tikz/tikz.code.tex

@@ -3365,7 +3365,8 @@
 \def\tikz@plot@function unction#1{%
   \def\tikz@plot@filename{\tikz@plot@prefix\tikz@plot@id}%
   \iftikz@plot@raw@gnuplot%
-    \def\tikz@plot@data{\pgfplotgnuplot[\tikz@plot@filename]{#1}}%
+    \def\tikz@plot@data{%
+      \pgfplotgnuplot[\tikz@plot@filename]{\pgfutil@trimspaces{#1}}}%
   \else%
     \iftikz@plot@parametric%
       \def\tikz@plot@data{\pgfplotgnuplot[\tikz@plot@filename]{%
@@ -3374,13 +3375,13 @@
           plot [t=\tikz@plot@domain]
           [\tikz@plot@xrange]
           [\tikz@plot@range]
-          #1}}%
+          \pgfutil@trimspaces{#1}}}%
     \else%
       \def\tikz@plot@data{\pgfplotgnuplot[\tikz@plot@filename]{%
           set samples \tikz@plot@samples;
           plot [x=\tikz@plot@domain]
           \ifx\tikz@plot@range\pgfutil@empty\else[\tikz@plot@range]\fi
-          #1}}%
+          \pgfutil@trimspaces{#1}}}%
     \fi%
   \fi%
   \tikz@@@plot%

tex/generic/pgf/modules/pgfmoduleplot.code.tex

@@ -481,14 +481,16 @@
   \pgfutilpreparefilename{#1.table}%
   \let\pgf@plottablefile=\pgfretval
   \let\pgf@plottablefile@quoted=\pgfretvalquoted
+  \begingroup
+  \endlinechar=-1 % suppress white space at end
   % Check, whether it is up-to-date
   \openin\pgfutil@inputcheck=\pgf@plotgnuplotfile\relax
   \ifeof\pgfutil@inputcheck%
   \else%
     \pgfutil@read\pgfutil@inputcheck to\pgf@temp% ignored
     \pgfutil@read\pgfutil@inputcheck to\pgf@plot@line%
     \closein\pgfutil@inputcheck
-    \edef\pgf@plot@code{#2\space}%
+    \edef\pgf@plot@code{#2}%
     \ifx\pgf@plot@code\pgf@plot@line%
       \openin\pgfutil@inputcheck=\pgfretval\relax
       \ifeof\pgfutil@inputcheck%
@@ -501,11 +503,12 @@
   \ifpgf@resample@plot%
     \immediate\openout\pgf@plotwrite=\pgf@plotgnuplotfile\relax
     \immediate\pgfutil@write\pgf@plotwrite{\pgf@gnuplot@head}%
-    \immediate\pgfutil@write\pgf@plotwrite{#2}%
+    \immediate\pgfutil@write\pgf@plotwrite{\pgf@plot@code}%
     \immediate\closeout\pgf@plotwrite%
     \pgfutil@shellescape{%
       \pgfkeysvalueof{/pgf/plot/gnuplot call} \pgf@plotgnuplotfile}%
   \fi%
+  \endgroup
 %  \let\pgf@savedparsexyline=\pgf@parsexyline%
 %  \let\pgf@parsexyline=\pgf@parsegnuplotxyline%
   \pgfplotxyfile{\pgf@plottablefile}%