Skip to content

Commit 991d17f

Browse files
committed
...
1 parent 4fb35f8 commit 991d17f

File tree

1 file changed

+29
-81
lines changed

1 file changed

+29
-81
lines changed

src/main/java/com/fasterxml/jackson/databind/ser/BeanPropertyWriter.java

Lines changed: 29 additions & 81 deletions
Original file line numberDiff line numberDiff line change
@@ -220,8 +220,7 @@ protected BeanPropertyWriter(BeanPropertyWriter base) {
220220
this(base, base._name);
221221
}
222222

223-
protected BeanPropertyWriter(BeanPropertyWriter base, SerializableString name)
224-
{
223+
protected BeanPropertyWriter(BeanPropertyWriter base, SerializableString name) {
225224
_name = name;
226225
_wrapperName = base._wrapperName;
227226

@@ -259,8 +258,7 @@ public BeanPropertyWriter rename(NameTransformer transformer) {
259258
*
260259
* @since 2.0
261260
*/
262-
public void assignSerializer(JsonSerializer<Object> ser)
263-
{
261+
public void assignSerializer(JsonSerializer<Object> ser) {
264262
// may need to disable check in future?
265263
if (_serializer != null && _serializer != ser) {
266264
throw new IllegalStateException("Can not override serializer");
@@ -273,8 +271,7 @@ public void assignSerializer(JsonSerializer<Object> ser)
273271
*
274272
* @since 2.0
275273
*/
276-
public void assignNullSerializer(JsonSerializer<Object> nullSer)
277-
{
274+
public void assignNullSerializer(JsonSerializer<Object> nullSer) {
278275
// may need to disable check in future?
279276
if (_nullSerializer != null && _nullSerializer != nullSer) {
280277
throw new IllegalStateException("Can not override null serializer");
@@ -306,37 +303,17 @@ public void setNonTrivialBaseType(JavaType t) {
306303
*/
307304

308305
// Note: also part of 'PropertyWriter'
309-
@Override
310-
public String getName() {
311-
return _name.getValue();
312-
}
306+
@Override public String getName() { return _name.getValue(); }
313307

314308
// Note: also part of 'PropertyWriter'
315-
@Override
316-
public PropertyName getFullName() {
317-
// !!! TODO: impl properly
309+
@Override public PropertyName getFullName() { // !!! TODO: impl properly
318310
return new PropertyName(_name.getValue());
319311
}
320312

321-
@Override
322-
public JavaType getType() {
323-
return _declaredType;
324-
}
325-
326-
@Override
327-
public PropertyName getWrapperName() {
328-
return _wrapperName;
329-
}
330-
331-
@Override
332-
public boolean isRequired() {
333-
return _metadata.isRequired();
334-
}
335-
336-
@Override
337-
public PropertyMetadata getMetadata() {
338-
return _metadata;
339-
}
313+
@Override public JavaType getType() { return _declaredType; }
314+
@Override public PropertyName getWrapperName() { return _wrapperName; }
315+
@Override public boolean isRequired() { return _metadata.isRequired(); }
316+
@Override public PropertyMetadata getMetadata() { return _metadata; }
340317

341318
@Override
342319
public <A extends Annotation> A getAnnotation(Class<A> acls) {
@@ -348,14 +325,10 @@ public <A extends Annotation> A getContextAnnotation(Class<A> acls) {
348325
return _contextAnnotations.get(acls);
349326
}
350327

351-
@Override
352-
public AnnotatedMember getMember() {
353-
return _member;
354-
}
328+
@Override public AnnotatedMember getMember() { return _member; }
355329

356330
// @since 2.3 -- needed so it can be overridden by unwrapping writer
357-
protected void _depositSchemaProperty(ObjectNode propertiesNode, JsonNode schemaNode)
358-
{
331+
protected void _depositSchemaProperty(ObjectNode propertiesNode, JsonNode schemaNode) {
359332
propertiesNode.set(getName(), schemaNode);
360333
}
361334

@@ -371,21 +344,16 @@ protected void _depositSchemaProperty(ObjectNode propertiesNode, JsonNode schema
371344
*
372345
* @return Value of the setting, if any; null if none.
373346
*/
374-
public Object getInternalSetting(Object key)
375-
{
376-
if (_internalSettings == null) {
377-
return null;
378-
}
379-
return _internalSettings.get(key);
347+
public Object getInternalSetting(Object key) {
348+
return (_internalSettings == null) ? null : _internalSettings.get(key);
380349
}
381350

382351
/**
383352
* Method for setting specific internal setting to given value
384353
*
385354
* @return Old value of the setting, if any (null if none)
386355
*/
387-
public Object setInternalSetting(Object key, Object value)
388-
{
356+
public Object setInternalSetting(Object key, Object value) {
389357
if (_internalSettings == null) {
390358
_internalSettings = new HashMap<Object,Object>();
391359
}
@@ -397,8 +365,7 @@ public Object setInternalSetting(Object key, Object value)
397365
*
398366
* @return Existing value of the setting, if any (null if none)
399367
*/
400-
public Object removeInternalSetting(Object key)
401-
{
368+
public Object removeInternalSetting(Object key) {
402369
Object removed = null;
403370
if (_internalSettings != null) {
404371
removed = _internalSettings.remove(key);
@@ -430,40 +397,29 @@ public Object removeInternalSetting(Object key)
430397
*
431398
* @since 2.3
432399
*/
433-
public boolean isUnwrapping() {
434-
return false;
435-
}
400+
public boolean isUnwrapping() { return false; }
436401

437402
public boolean willSuppressNulls() { return _suppressNulls; }
438403

439404
// Needed by BeanSerializer#getSchema
440-
public JsonSerializer<Object> getSerializer() {
441-
return _serializer;
442-
}
405+
public JsonSerializer<Object> getSerializer() { return _serializer; }
443406

444-
public JavaType getSerializationType() {
445-
return _cfgSerializationType;
446-
}
407+
public JavaType getSerializationType() { return _cfgSerializationType; }
447408

448409
public Class<?> getRawSerializationType() {
449410
return (_cfgSerializationType == null) ? null : _cfgSerializationType.getRawClass();
450411
}
451412

452-
public Class<?> getPropertyType()
453-
{
454-
if (_accessorMethod != null) {
455-
return _accessorMethod.getReturnType();
456-
}
457-
return _field.getType();
413+
public Class<?> getPropertyType() {
414+
return (_accessorMethod != null) ? _accessorMethod.getReturnType() : _field.getType();
458415
}
459416

460417
/**
461418
* Get the generic property type of this property writer.
462419
*
463420
* @return The property type, or null if not found.
464421
*/
465-
public Type getGenericPropertyType()
466-
{
422+
public Type getGenericPropertyType() {
467423
if (_accessorMethod != null) {
468424
return _accessorMethod.getGenericReturnType();
469425
}
@@ -484,9 +440,7 @@ public Type getGenericPropertyType()
484440
* @deprecated since 2.2, use {@link #isRequired()} instead.
485441
*/
486442
@Deprecated
487-
protected boolean isRequired(AnnotationIntrospector intr) {
488-
return _metadata.isRequired();
489-
}
443+
protected boolean isRequired(AnnotationIntrospector intr) { return _metadata.isRequired(); }
490444

491445
/*
492446
/**********************************************************
@@ -500,8 +454,7 @@ protected boolean isRequired(AnnotationIntrospector intr) {
500454
* using appropriate serializer.
501455
*/
502456
@Override
503-
public void serializeAsField(Object bean, JsonGenerator jgen, SerializerProvider prov)
504-
throws Exception
457+
public void serializeAsField(Object bean, JsonGenerator jgen, SerializerProvider prov) throws Exception
505458
{
506459
Object value = get(bean);
507460
// Null handling is bit different, check that first
@@ -516,10 +469,10 @@ public void serializeAsField(Object bean, JsonGenerator jgen, SerializerProvider
516469
JsonSerializer<Object> ser = _serializer;
517470
if (ser == null) {
518471
Class<?> cls = value.getClass();
519-
PropertySerializerMap map = _dynamicSerializers;
520-
ser = map.serializerFor(cls);
472+
PropertySerializerMap m = _dynamicSerializers;
473+
ser = m.serializerFor(cls);
521474
if (ser == null) {
522-
ser = _findAndAddDynamic(map, cls, prov);
475+
ser = _findAndAddDynamic(m, cls, prov);
523476
}
524477
}
525478
// and then see if we must suppress certain values (default, empty)
@@ -552,8 +505,7 @@ public void serializeAsField(Object bean, JsonGenerator jgen, SerializerProvider
552505
* @since 2.3
553506
*/
554507
@Override
555-
public void serializeAsOmittedField(Object bean, JsonGenerator jgen, SerializerProvider prov)
556-
throws Exception
508+
public void serializeAsOmittedField(Object bean, JsonGenerator jgen, SerializerProvider prov) throws Exception
557509
{
558510
if (!jgen.canOmitFields()) {
559511
jgen.writeOmittedField(_name.getValue());
@@ -728,15 +680,11 @@ public final Object get(Object bean) throws Exception
728680
return _field.get(bean);
729681
}
730682

731-
protected void _handleSelfReference(Object bean, JsonSerializer<?> ser)
732-
throws JsonMappingException
733-
{
683+
protected void _handleSelfReference(Object bean, JsonSerializer<?> ser) throws JsonMappingException {
734684
/* 05-Feb-2012, tatu: Usually a problem, but NOT if we are handling
735685
* object id; this may be the case for BeanSerializers at least.
736686
*/
737-
if (ser.usesObjectId()) {
738-
return;
739-
}
687+
if (ser.usesObjectId()) { return; }
740688
throw new JsonMappingException("Direct self-reference leading to cycle");
741689
}
742690

0 commit comments

Comments
 (0)