From cc1e13d671c7f53b2eb1e94812d74098c9b622d2 Mon Sep 17 00:00:00 2001 From: Daniel Raap Date: Wed, 12 Feb 2025 16:25:08 +0100 Subject: [PATCH 1/4] remove_separators() works when no separators exist --- plugins/module_utils/interface.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/module_utils/interface.py b/plugins/module_utils/interface.py index 3d9936c9..52f97643 100644 --- a/plugins/module_utils/interface.py +++ b/plugins/module_utils/interface.py @@ -383,7 +383,7 @@ def _remove_all_rules(self, interface): def _remove_all_separators(self, interface): """ delete all interface separators """ todel = [] - separators = self.pfsense.rules.find('separator') + separators = self.pfsense.rules.find('separator') or [] for interface_elt in separators: if interface_elt.tag != interface: continue From 8e636cf902e993e24c1534ddf330af2fa52ce296 Mon Sep 17 00:00:00 2001 From: Daniel Raap Date: Thu, 13 Feb 2025 09:28:32 +0100 Subject: [PATCH 2/4] add changelog fragment for bugfix --- .../170_pfsense_interface_fix_remove_all_separators.yml | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 changelogs/fragments/170_pfsense_interface_fix_remove_all_separators.yml diff --git a/changelogs/fragments/170_pfsense_interface_fix_remove_all_separators.yml b/changelogs/fragments/170_pfsense_interface_fix_remove_all_separators.yml new file mode 100644 index 00000000..3ca203a1 --- /dev/null +++ b/changelogs/fragments/170_pfsense_interface_fix_remove_all_separators.yml @@ -0,0 +1,2 @@ +bugfixes: + - pfsense_interface - fixes removal of an interface with ``state: absent``. _remove_all_separators() works when no separator exists for that interface. (https://github.com/pfsensible/core/issues/170) From 52c428eb71d57d34aead4ae417df5b69415c9190 Mon Sep 17 00:00:00 2001 From: Daniel Raap Date: Thu, 13 Feb 2025 09:45:03 +0100 Subject: [PATCH 3/4] changelog list entry must be a string --- .../170_pfsense_interface_fix_remove_all_separators.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/changelogs/fragments/170_pfsense_interface_fix_remove_all_separators.yml b/changelogs/fragments/170_pfsense_interface_fix_remove_all_separators.yml index 3ca203a1..97971cf3 100644 --- a/changelogs/fragments/170_pfsense_interface_fix_remove_all_separators.yml +++ b/changelogs/fragments/170_pfsense_interface_fix_remove_all_separators.yml @@ -1,2 +1,2 @@ bugfixes: - - pfsense_interface - fixes removal of an interface with ``state: absent``. _remove_all_separators() works when no separator exists for that interface. (https://github.com/pfsensible/core/issues/170) + - "pfsense_interface - fixes removal of an interface with ``state: absent``. _remove_all_separators() works when no separator exists for that interface. (https://github.com/pfsensible/core/issues/170)" From b34f6d863074355f0a52399af08d4dba1d6b9a3c Mon Sep 17 00:00:00 2001 From: Daniel Raap Date: Thu, 13 Feb 2025 09:46:00 +0100 Subject: [PATCH 4/4] remove backtick escape in string as it is not part of yaml --- .../170_pfsense_interface_fix_remove_all_separators.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/changelogs/fragments/170_pfsense_interface_fix_remove_all_separators.yml b/changelogs/fragments/170_pfsense_interface_fix_remove_all_separators.yml index 97971cf3..a016d88e 100644 --- a/changelogs/fragments/170_pfsense_interface_fix_remove_all_separators.yml +++ b/changelogs/fragments/170_pfsense_interface_fix_remove_all_separators.yml @@ -1,2 +1,2 @@ bugfixes: - - "pfsense_interface - fixes removal of an interface with ``state: absent``. _remove_all_separators() works when no separator exists for that interface. (https://github.com/pfsensible/core/issues/170)" + - "pfsense_interface - fixes removal of an interface with `state: absent`. _remove_all_separators() works when no separator exists for that interface. (https://github.com/pfsensible/core/issues/170)"