Fix empty if-chain same-line else removal#577
Closed
tristanmanchester wants to merge 1 commit into
Closed
Conversation
Owner
|
Thanks @tristanmanchester for the fix. Final decision: accepted and applied. I applied the same-line else-chain fix as reviewed. The focused TypeScript fixer test passed, and the full project plus TypeScript language tests passed. Local commit: Closing this PR as applied. |
Owner
|
Closing after accepted review decision; applied locally as 596b1ed7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
} else {continuations in_find_if_chain_end()so brace depth stays balanced across the full if/else chainbreakpaths withcontinue, allowing the scanner to process the{that opens the else blockTesting
uv run --with pytest python -m pytest desloppify/tests/lang/typescript/test_ts_empty_if_chain_fixer_direct.py desloppify/tests/lang/typescript/test_typescript_detectors_fixers_and_wrappers_split_direct.py