Merge pull request #450 from sims1253/feat/r-code-smell-detectors

Clean, well-structured contribution. The `custom_phases` extension point is a great addition to the generic framework — it means any language plugin can inject detection phases without converting to a full plugin. The smell catalog covers the right R anti-patterns with good severity calibration, and the tree-sitter + regex fallback approach for `library_in_function` is thoughtful.

Tests are thorough — 22 test cases covering detection, false positive suppression, comment/string handling, nesting, and graceful error handling.

Thanks @sims1253!

Author: peteromallet

desloppify/languages/_framework/generic_support/core.py

@@ -10,7 +10,7 @@
 from typing import Any
 
 from desloppify.engine.policy.zones import ZoneRule
-from desloppify.languages._framework.base.types import LangConfig
+from desloppify.languages._framework.base.types import DetectorPhase, LangConfig
 from .capabilities import (
     SHARED_PHASE_LABELS,
     capability_report,
@@ -60,6 +60,7 @@ def generic_lang(
     external_test_dirs: list[str] | None = None,
     test_file_extensions: list[str] | None = None,
     frameworks: bool = False,
+    custom_phases: list[DetectorPhase] | None = None,
 ) -> LangConfig:
     """Build and register a generic language plugin from tool specs.
 
@@ -86,6 +87,7 @@ def generic_lang(
         entry_patterns=entry_patterns,
         external_test_dirs=external_test_dirs,
         test_file_extensions=test_file_extensions,
+        custom_phases=custom_phases,
     )
 
     from desloppify.languages import register_generic_lang
@@ -102,6 +104,7 @@ def generic_lang(
         has_treesitter=has_treesitter,
         extract_fn=extract_fn,
         dep_graph_fn=dep_graph_fn,
+        custom_phases=opts.custom_phases,
     )
 
     cfg = LangConfig(

desloppify/languages/_framework/generic_support/registration.py

@@ -41,6 +41,7 @@ class GenericLangOptions:
     entry_patterns: list[str] | None = None
     external_test_dirs: list[str] | None = None
     test_file_extensions: list[str] | None = None
+    custom_phases: list[DetectorPhase] | None = None
 
 
 def _register_generic_tool_specs(tool_specs: list[dict[str, Any]]) -> dict[str, FixerConfig]:
@@ -106,6 +107,7 @@ def _build_generic_phases(
     has_treesitter: bool,
     extract_fn,
     dep_graph_fn,
+    custom_phases: list[DetectorPhase] | None = None,
 ) -> list[DetectorPhase]:
     from desloppify.languages._framework.base.phase_builders import (
         detector_phase_security,
@@ -141,6 +143,9 @@ def _build_generic_phases(
         phases.append(_make_coupling_phase(dep_graph_fn))
         phases.append(detector_phase_test_coverage())
 
+    if custom_phases:
+        phases.extend(custom_phases)
+
     phases.extend(shared_subjective_duplicates_tail())
     return phases
 

desloppify/languages/r/__init__.py

@@ -1,7 +1,9 @@
-"""R language plugin — Jarl, lintr + tree-sitter."""
+"""R language plugin — Jarl, lintr + tree-sitter + R-specific smells."""
 
+from desloppify.languages._framework.base.types import DetectorPhase
 from desloppify.languages._framework.generic_support.core import generic_lang
 from desloppify.languages._framework.treesitter import R_SPEC
+from desloppify.languages.r.phases_smells import phase_smells
 
 generic_lang(
     name="r",
@@ -31,6 +33,9 @@
     detect_markers=["DESCRIPTION", ".Rproj"],
     default_src="R",
     treesitter_spec=R_SPEC,
+    custom_phases=[
+        DetectorPhase("R code smells", phase_smells),
+    ],
 )
 
 __all__ = [

desloppify/languages/r/detectors/__init__.py

@@ -0,0 +1 @@
+