-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests are not robust to parallel running #13
Comments
@Altai-man So they only pass because |
@jnthn not sure about prove, but |
I see the extent of the problem now. As indicated by @antoniogamiz, in this answer in Stackoverflow, the problem is that we are never updating a cache. Caches can't simply be updated. What we were doing before was creating a cache in a program, and then using the cache from another program. As ugexe says, the first time we do "load" is when we cache the results, so by creating the Pod::To::Cached object we "freeze" the cache. Subsequent calls to load will simply not work. |
@antoniogamiz probably in the other issue... Let's leave this for the parallel update, which is a different problem. It would require not only the tests being independent, but also use random temporary directory to avoid race conditions. |
Right now, test files assume running in a certain order specified by file names.
I am not sure whether we want to teach Comma about something like "Execute those tests in order in a single thread", but right now parallel execution, even with a single worker, will lead to failed tests, which is not always stable.
The text was updated successfully, but these errors were encountered: