Merge pull request #200 from waterkip/GH-195-nameformatid_deprecation_warning

Add deprecation warning for nameid_format in Protocol::AuthnRequest

Author: waterkip

lib/Net/SAML2/Protocol/AuthnRequest.pm

@@ -179,6 +179,9 @@ around BUILDARGS => sub {
 
     my %params = @_;
     if ($params{nameid_format} && !defined $params{nameidpolicy_format}) {
+        warn "You are using nameid_format, this field has changed to "
+          . "nameidpolicy_format. This field will be used for other purposes "
+          . "in an upcoming release. Please change your code ASAP.";
         $params{nameidpolicy_format} = $params{nameid_format};
     }
 

lib/Net/SAML2/SP.pm

@@ -322,10 +322,10 @@ sub authn_request {
     my (%params)        = @_;
 
     return Net::SAML2::Protocol::AuthnRequest->new(
-        issueinstant  => DateTime->now,
-        issuer        => $self->id,
-        destination   => $destination,
-        nameid_format => $nameid_format || '',
+        issueinstant        => DateTime->now,
+        issuer              => $self->id,
+        destination         => $destination,
+        nameidpolicy_format => $nameid_format || '',
         %params,
     );
 

t/09-authn-request.t

@@ -17,7 +17,7 @@ $override->override('Net::SAML2::Protocol::AuthnRequest::_build_id' =>
 {
     my ($ar, $xp) = net_saml2_authnreq(
         nameid        => 'mynameid',
-        nameid_format =>
+        nameidpolicy_format =>
             'urn:oasis:names:tc:SAML:2.0:nameid-format:persistent',
         nameid_allow_create  => 1,
         issuer_namequalifier => 'bar',