Merge pull request #1221 from percona/revert-1220-PBM-1608-gcs-debug-log-levels

Revert "PBM-1608: Add config option to enable debug for GCS storage"

Author: boris-ilijic

packaging/conf/pbm-conf-reference.yml

@@ -160,10 +160,6 @@
 ## The maximum object size that will be stored on the storage
 #      maxObjSizeGB: 5018
 
-## Enable debug trace of HTTP communication
-#      debugTrace: true
-
-
 #--------------------Filesystem Configuration---------------------------
 #  type:
 #    filesystem:

pbm/storage/gcs/config.go

@@ -17,7 +17,6 @@ type Config struct {
 	// https://pkg.go.dev/cloud.google.com/go/storage#Writer
 	ChunkSize    int      `bson:"chunkSize,omitempty" json:"chunkSize,omitempty" yaml:"chunkSize,omitempty"`
 	MaxObjSizeGB *float64 `bson:"maxObjSizeGB,omitempty" json:"maxObjSizeGB,omitempty" yaml:"maxObjSizeGB,omitempty"`
-	DebugTrace   bool     `bson:"debugTrace,omitempty" json:"debugTrace,omitempty" yaml:"debugTrace,omitempty"`
 
 	Retryer *Retryer `bson:"retryer,omitempty" json:"retryer,omitempty" yaml:"retryer,omitempty"`
 }

pbm/storage/gcs/google_client.go

@@ -5,7 +5,6 @@ import (
 	"encoding/json"
 	"fmt"
 	"io"
-	"log/slog"
 	"path"
 	"strings"
 	"time"
@@ -50,21 +49,7 @@ func newGoogleClient(cfg *Config, l log.LogEvent) (*googleClient, error) {
 		return nil, errors.Wrap(err, "marshal GCS credentials")
 	}
 
-	clOpts := []option.ClientOption{
-		option.WithCredentialsJSON(creds),
-	}
-	if cfg.DebugTrace {
-		h := slog.NewTextHandler(l.GetLogger(), &slog.HandlerOptions{
-			Level: slog.LevelDebug,
-		})
-		gcsLogger := slog.New(h)
-		clOpts = append(clOpts, option.WithLogger(gcsLogger))
-	}
-
-	cli, err := storagegcs.NewClient(
-		ctx,
-		clOpts...,
-	)
+	cli, err := storagegcs.NewClient(ctx, option.WithCredentialsJSON(creds))
 	if err != nil {
 		return nil, errors.Wrap(err, "new GCS client")
 	}