Avoid false positive useless catch (#141)

* Add failing test

* Try

* Fix lint

* Fix phpstan

Author: VincentLanglet

src/Rules/ThrowsPhpDocRule.php

@@ -485,7 +485,15 @@ private function processFunction(Node\FunctionLike $node, Scope $scope): array
 				throw new ShouldNotHappenException();
 			}
 
-			if ($classReflection->getNativeReflection()->getMethod($methodReflection->getName())->isAbstract()) {
+			try {
+				$nativeMethodReflection = $classReflection->getNativeReflection()->getMethod(
+					$methodReflection->getName()
+				);
+			} catch (ReflectionException $exception) {
+				throw new ShouldNotHappenException();
+			}
+
+			if ($nativeMethodReflection->isAbstract()) {
 				return [];
 			}
 		}
@@ -551,8 +559,14 @@ private function filterUnusedExceptions(array $declaredThrows, array $usedThrows
 
 		if (!$this->reportUnusedCheckedThrowsInSubtypes && $functionReflection instanceof MethodReflection) {
 			$declaringClass = $functionReflection->getDeclaringClass();
-			$nativeClassReflection = $declaringClass->getNativeReflection();
-			$nativeMethodReflection = $nativeClassReflection->getMethod($functionReflection->getName());
+
+			try {
+				$nativeMethodReflection = $declaringClass->getNativeReflection()->getMethod(
+					$functionReflection->getName()
+				);
+			} catch (ReflectionException $exception) {
+				throw new ShouldNotHappenException();
+			}
 
 			if ($this->isImplementation($nativeMethodReflection)) {
 				return [];
@@ -634,10 +648,6 @@ private function processCatch(Catch_ $node): array
 				continue;
 			}
 
-			if (!$this->reportUnusedCatchesOfUncheckedExceptions) {
-				$caughtExceptions = $this->checkedExceptionService->filterCheckedExceptions($caughtExceptions);
-			}
-
 			if (count($caughtExceptions) > 0) {
 				continue;
 			}

tests/src/Rules/ThrowsPhpDocRuleTest.php

@@ -2,6 +2,7 @@
 
 namespace Pepakriz\PHPStanExceptionRules\Rules;
 
+use LogicException;
 use Pepakriz\PHPStanExceptionRules\CheckedExceptionService;
 use Pepakriz\PHPStanExceptionRules\DefaultThrowTypeExtension;
 use Pepakriz\PHPStanExceptionRules\DefaultThrowTypeService;
@@ -38,6 +39,20 @@ class ThrowsPhpDocRuleTest extends RuleTestCase
 	 */
 	private $reportCheckedThrowsInGlobalScope = false;
 
+	/**
+	 * @var string[]
+	 */
+	private $checkedExceptions = [
+		RuntimeException::class,
+		CheckedException::class,
+		ReflectionException::class,
+	];
+
+	/**
+	 * @var string[]
+	 */
+	private $uncheckedExceptions = [];
+
 	/**
 	 * @var array<string, string>
 	 */
@@ -67,11 +82,8 @@ protected function getRule(): Rule
 
 		return new ThrowsPhpDocRule(
 			new CheckedExceptionService(
-				[
-					RuntimeException::class,
-					CheckedException::class,
-					ReflectionException::class,
-				]
+				$this->checkedExceptions,
+				$this->uncheckedExceptions
 			),
 			new DynamicThrowTypeService(
 				$extensions,
@@ -122,6 +134,29 @@ public function testUnusedCatches(): void
 		$this->analyseFile(__DIR__ . '/data/unused-catches.php');
 	}
 
+	public function testUnusedCatchesUncheckedExceptions(): void
+	{
+		$this->methodThrowTypes = [
+			Phar::class => [
+				'extractTo' => [
+					RuntimeException::class,
+				],
+			],
+			UnusedCatches::class => [
+				'methodWithDefaultThrowType' => [
+					FooException::class,
+				],
+			],
+		];
+
+		$this->checkedExceptions = [];
+		$this->uncheckedExceptions = [
+			LogicException::class,
+		];
+
+		$this->analyseFile(__DIR__ . '/data/unused-catches.php');
+	}
+
 	public function testAllUnusedCatches(): void
 	{
 		$this->reportUnusedCatchesOfUncheckedExceptions = true;

tests/src/Rules/data/unused-catches.php

@@ -94,6 +94,15 @@ public function correctCatchMethodCallWithThrows(): void
 		}
 	}
 
+	public function correctCatchMethodCallWithThrows2(): void
+	{
+		try {
+			$this->throwLogic();
+		} catch (\Throwable $e) {
+
+		}
+	}
+
 	private function someVoidMethod(): void
 	{
 	}