[Hotfix] Fix crash reading annotations of anonymous classes (fix #71) (#72)

As  the `ThrowsAnnotationReader` class is `@internal`, there is no BC break.

Author: marcospassos

src/Rules/ThrowsPhpDocRule.php

@@ -40,8 +40,6 @@
 use PHPStan\Type\TypeCombinator;
 use PHPStan\Type\TypeUtils;
 use PHPStan\Type\VoidType;
-use ReflectionException;
-use ReflectionFunction;
 use function array_diff;
 use function array_filter;
 use function array_map;
@@ -477,23 +475,11 @@ private function filterUnusedExceptions(array $declaredThrows, array $usedThrows
 
 		$unusedThrows = array_diff($unusedThrows, TypeUtils::getDirectClassNames($defaultThrowsType));
 
-		try {
-			if ($functionReflection instanceof MethodReflection) {
-				$nativeClassReflection = $functionReflection->getDeclaringClass()->getNativeReflection();
-				$nativeFunctionReflection = $nativeClassReflection->getMethod($functionReflection->getName());
-
-			} else {
-				$nativeFunctionReflection = new ReflectionFunction($functionReflection->getName());
-			}
-		} catch (ReflectionException $exception) {
-			return $unusedThrows;
-		}
-
 		if (!$this->ignoreDescriptiveUncheckedExceptions) {
 			return $unusedThrows;
 		}
 
-		$throwsAnnotations = $this->throwsAnnotationReader->read($nativeFunctionReflection);
+		$throwsAnnotations = $this->throwsAnnotationReader->read($scope);
 
 		return array_filter($unusedThrows, static function (string $type) use ($throwsAnnotations, $usedThrowsAnnotations): bool {
 			return !in_array($type, $usedThrowsAnnotations, true)

src/ThrowsAnnotationReader.php

@@ -6,12 +6,14 @@
 use PhpParser\NodeTraverser;
 use PhpParser\NodeVisitorAbstract;
 use PHPStan\Analyser\NameScope;
+use PHPStan\Analyser\Scope;
 use PHPStan\Parser\Parser;
 use PHPStan\PhpDocParser\Lexer\Lexer;
 use PHPStan\PhpDocParser\Parser\PhpDocParser;
 use PHPStan\PhpDocParser\Parser\TokenIterator;
-use ReflectionFunctionAbstract;
-use ReflectionMethod;
+use PHPStan\Reflection\MethodReflection;
+use ReflectionException;
+use ReflectionFunction;
 use function sprintf;
 use function strtolower;
 
@@ -46,31 +48,54 @@ public function __construct(Parser $phpParser, Lexer $phpDocLexer, PhpDocParser
 	/**
 	 * @return string[][]
 	 */
-	public function read(ReflectionFunctionAbstract $reflection): array
+	public function read(Scope $scope): array
 	{
-		$functionName = $reflection->getName();
+		$reflection = $scope->getFunction();
 
-		if (!isset($this->annotations[$functionName])) {
-			$this->annotations[$functionName] = $this->parse($reflection);
+		if ($reflection === null) {
+			return [];
+		}
+
+		$namespace = $scope->getNamespace();
+		$sourceFile = $scope->getFile();
+
+		$key = $namespace . '::' . $sourceFile . '::';
+
+		$classReflection = $scope->getClassReflection();
+
+		if ($classReflection !== null) {
+			$key .= $classReflection->getName();
+		}
+
+		$key .= $reflection->getName();
+
+		if (!isset($this->annotations[$key])) {
+			$this->annotations[$key] = $this->parse($reflection, $sourceFile, $namespace);
 		}
 
-		return $this->annotations[$functionName];
+		return $this->annotations[$key];
 	}
 
 	/**
+	 * @param \PHPStan\Reflection\FunctionReflection|\PHPStan\Reflection\MethodReflection $reflection
+	 *
 	 * @return string[][]
 	 */
-	private function parse(ReflectionFunctionAbstract $reflection): array
+	private function parse($reflection, string $sourceFile, ?string $namespace = null): array
 	{
-		$docComment = $reflection->getDocComment();
+		try {
+			$docBlock = $this->getDocblock($reflection);
+		} catch (ReflectionException $exception) {
+			return [];
+		}
 
-		if ($docComment === false) {
+		if ($docBlock === null) {
 			return [];
 		}
 
-		$tokens = new TokenIterator($this->phpDocLexer->tokenize($docComment));
+		$tokens = new TokenIterator($this->phpDocLexer->tokenize($docBlock));
 		$phpDocNode = $this->phpDocParser->parse($tokens);
-		$nameScope = $this->createNameScope($reflection);
+		$nameScope = $this->createNameScope($sourceFile, $namespace);
 
 		$annotations = [];
 		foreach ($phpDocNode->getThrowsTagValues() as $tagValue) {
@@ -86,17 +111,31 @@ private function parse(ReflectionFunctionAbstract $reflection): array
 		return $annotations;
 	}
 
-	private function createNameScope(ReflectionFunctionAbstract $reflection): NameScope
+	/**
+	 * @param \PHPStan\Reflection\FunctionReflection|\PHPStan\Reflection\MethodReflection $reflection
+	 *
+	 * @throws ReflectionException
+	 */
+	private function getDocblock($reflection): ?string
 	{
-		$namespace = $reflection instanceof ReflectionMethod ?
-			$reflection->getDeclaringClass()->getNamespaceName() :
-			$reflection->getNamespaceName();
+		if ($reflection instanceof MethodReflection) {
+			$declaringClass = $reflection->getDeclaringClass();
+			$nativeClassReflection = $declaringClass->getNativeReflection();
+			$nativeMethodReflection = $nativeClassReflection->getMethod($reflection->getName());
+			$docBlock = $nativeMethodReflection->getDocComment();
 
-		/** @var string $fileName */
-		$fileName = $reflection->getFileName();
-		$usesMap = $this->getUsesMap($fileName, $namespace);
+			return $docBlock !== false ? $docBlock : null;
+		}
 
-		return new NameScope($namespace, $usesMap);
+		$functionReflection = new ReflectionFunction($reflection->getName());
+		$docBlock = $functionReflection->getDocComment();
+
+		return $docBlock !== false ? $docBlock : null;
+	}
+
+	private function createNameScope(string $sourceFile, ?string $namespace = null): NameScope
+	{
+		return new NameScope($namespace, $this->getUsesMap($sourceFile, (string) $namespace));
 	}
 
 	/**
@@ -114,7 +153,7 @@ private function getUsesMap(string $fileName, string $namespace): array
 	/**
 	 * @return string[][]
 	 */
-	private function createUsesMap(string $fileName): array
+	private function createUsesMap(string $sourceFile): array
 	{
 		$visitor = new class extends NodeVisitorAbstract {
 
@@ -170,7 +209,7 @@ private function addUse(string $alias, string $className): void
 
 		$traverser = new NodeTraverser();
 		$traverser->addVisitor($visitor);
-		$traverser->traverse($this->phpParser->parseFile($fileName));
+		$traverser->traverse($this->phpParser->parseFile($sourceFile));
 
 		return $visitor->uses;
 	}

tests/src/Rules/data/unused-descriptive-throws.php

@@ -103,14 +103,14 @@ public function unusedBarAnnotation(): void // error: Unused @throws Pepakriz\PH
 		$this->throwFooExceptions();
 	}
 
-/**
- * @throws FooException
- * @throws BarException Description
- */
-public function unusedDescriptiveAnnotation(): void // error: Unused @throws Pepakriz\PHPStanExceptionRules\Rules\UnusedDescriptiveThrows\BarException annotation
-{
-	$this->throwFooExceptions();
-}
+	/**
+	 * @throws FooException
+	 * @throws BarException Description
+	 */
+	public function unusedDescriptiveAnnotation(): void // error: Unused @throws Pepakriz\PHPStanExceptionRules\Rules\UnusedDescriptiveThrows\BarException annotation
+	{
+		$this->throwFooExceptions();
+	}
 
 	/**
 	 * @throws LogicException Description.
@@ -137,3 +137,15 @@ public function unusedLogic(): void // error: Unused @throws LogicException anno
 	}
 
 }
+
+new class {
+
+	/**
+	 * @throws RuntimeException Overridden description.
+	 */
+	public function descriptiveAnnotationAlias(): void
+	{
+		throw new RuntimeException();
+	}
+
+};