review: improv logging of cache invalidation

Author: dcleao

core/src/main/java/org/pentaho/platform/engine/security/authorization/core/caching/MemoryAuthorizationDecisionCache.java

@@ -74,6 +74,9 @@ private class SessionCacheData {
 
     private final ReentrantReadWriteLock lock = new ReentrantReadWriteLock();
 
+    @NonNull
+    private final String sessionKey;
+
     /**
      * Stores the set of sessions associated with this session cache data.
      * <p>
@@ -91,8 +94,10 @@ private class SessionCacheData {
     @NonNull
     private final Cache<IAuthorizationDecisionCacheKey, IAuthorizationDecision> cache;
 
-    public SessionCacheData( @NonNull Cache<IAuthorizationDecisionCacheKey, IAuthorizationDecision> cache,
+    public SessionCacheData( @NonNull String sessionKey,
+                             @NonNull Cache<IAuthorizationDecisionCacheKey, IAuthorizationDecision> cache,
                              @NonNull IPentahoSession session ) {
+      this.sessionKey = sessionKey;
       this.cache = cache;
 
       addSessionCore( session );
@@ -174,6 +179,13 @@ public boolean isStale() {
     }
 
     public void invalidate( @NonNull IAuthorizationDecisionCacheKey key ) {
+      if ( logger.isTraceEnabled() ) {
+        logger.trace(
+          String.format(
+            "Invalidating cache entry for key '%s' in session cache for '%s'",
+            key, sessionKey ) );
+      }
+
       cache.invalidate( key );
     }
 
@@ -195,6 +207,17 @@ public void invalidateAll( @NonNull Predicate<IAuthorizationDecisionCacheKey> pr
         .filter( predicate )
         .toList();
 
+      if ( logger.isTraceEnabled() ) {
+        for ( var key : invalidateRequests ) {
+          logger.trace(
+            String.format(
+              "Invalidating cache entry for key '%s' in session cache for '%s'",
+              key, sessionKey ) );
+        }
+
+        logger.trace( String.format( "Session cache disposed for '%s'", sessionKey ) );
+      }
+
       cache.invalidateAll( invalidateRequests );
     }
 
@@ -210,6 +233,10 @@ public void dispose() {
       } finally {
         lock.writeLock().unlock();
       }
+
+      if ( logger.isTraceEnabled() ) {
+        logger.trace( String.format( "Session cache disposed for '%s'", sessionKey ) );
+      }
     }
   }
 
@@ -513,7 +540,7 @@ protected Cache<IAuthorizationDecisionCacheKey, IAuthorizationDecision> getSessi
       }
 
       var cache = createSessionCache();
-      cacheData = new SessionCacheData( cache, session );
+      cacheData = new SessionCacheData( sessionKey, cache, session );
       cacheBySessionKey.put( sessionKey, cacheData );
       return cache;
     } finally {