Add: Survive The Nights #58

QuintenQVD0 · 2024-08-11T12:15:08Z

Description

Closes #49

Checklist for all submissions

Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?
Have you tested and reviewed your changes with confidence that everything works?
Did you branch your changes and PR from that branch and not from your master branch?
- If not, why?:

New egg Submissions

Does your submission pass tests (server is connectable)?
Does your egg use a custom docker image?
- Have you tried to use a generic image?
- Did you PR the necessary changes to make it work?
Have you added the egg to the main README.md and any other README files in subdirectories of the egg (e.g /game_eggs) according to the alphabetical order?
Have you added a unique README.md for the egg you are adding according to the alphabetical order?
You verify that the start command applied does not use a shell script
- If some script is needed then it is part of a current yolk or a PR to add one
The egg was exported from the panel

scootz · 2025-01-31T21:26:59Z

I would suggest adding a variables for "useSteamRelays", "welcomeMessage", "recurringWelcomeMessage", "pvpDisabled". With my setup, I had to disable useSteamRelays for anyone to connect to the server.

edit I think I'm understanding this a bit more. What I'm suggesting about the new variables should be moved to another PR? I've never done a PR before so I'm not sure what to do. Off to google I go.

edit So I've learned that I can offer suggested edits and have tried to do it this morning but it created 15 or so comments with code changes you could approve/merge. I thought that was a bit much and deleted the pending comments. If this is indeed the way to go to suggest edits, I'll do it again. I just didn't want to do it in case there was a 'better' way of doing this without spamming comments/giving you a bunch of notifications etc.

scootz · 2025-02-03T00:32:58Z

Something I did just notice now, and changed the other day but forgot to mention here. QUERY_PORT is not user editable. Shouldn't it be set to true?

QuintenQVD0 · 2025-02-03T07:33:52Z

Something I did just notice now, and changed the other day but forgot to mention here. QUERY_PORT is not user editable. Shouldn't it be set to true?

no, a port should never be editable by a user

QuintenQVD0 · 2025-02-03T07:35:00Z

You can add comments to the egg, that is not a problem

scootz

These are the changes I think should be added/changed.

survive_the_nights/egg-survive-the-nights.json

survive_the_nights/egg-pterodactyl-survive-the-nights.json

survive_the_nights/egg-survive-the-nights.json

scootz · 2025-02-03T17:22:43Z

survive_the_nights/egg-survive-the-nights.json

+        "files": "{\n    \".\/Config\/ServerConfig.txt\": {\n        \"parser\": \"file\",\n        \"find\": {\n            \"serverPort=\": \"serverPort={{server.allocations.default.port}}\",\n            \"serverIP=\": \"serverIP=0.0.0.0\",\n            \"serverName=\": \"serverName={{server.environment.SERVER_NAME}}\",\n            \"serverPassword=\": \"serverPassword={{server.environment.SERVER_PASSWORD}}\",\n            \"showInPublicLobby=\": \"showInPublicLobby={{server.environment.SERVER_PUBLIC}}\",\n            \"serverOwner=\": \"serverOwner={{server.environment.SERVER_OWNER}}\",\n            \"worldname=\": \"worldname={{server.environment.WORLDNAME}}\",\n            \"queryPort=\": \"queryPort={{server.environment.QUERY_PORT}}\"\n        }\n    }\n}",
+        "startup": "{\r\n  \"done\":[\r\n    \"*** Server Connected To STEAM *** \",\r\n    \"to start the server ready to accept players!\"\r\n  ]\r\n}",


Suggested change

"files": "{\n \".\/Config\/ServerConfig.txt\": {\n \"parser\": \"file\",\n \"find\": {\n \"serverPort=\": \"serverPort={{server.allocations.default.port}}\",\n \"serverIP=\": \"serverIP=0.0.0.0\",\n \"serverName=\": \"serverName={{server.environment.SERVER_NAME}}\",\n \"serverPassword=\": \"serverPassword={{server.environment.SERVER_PASSWORD}}\",\n \"showInPublicLobby=\": \"showInPublicLobby={{server.environment.SERVER_PUBLIC}}\",\n \"serverOwner=\": \"serverOwner={{server.environment.SERVER_OWNER}}\",\n \"worldname=\": \"worldname={{server.environment.WORLDNAME}}\",\n \"queryPort=\": \"queryPort={{server.environment.QUERY_PORT}}\"\n }\n }\n}",

"startup": "{\r\n \"done\":[\r\n \"*** Server Connected To STEAM *** \",\r\n \"to start the server ready to accept players!\"\r\n ]\r\n}",

"files": "{\n \".\/Config\/ServerConfig.txt\": {\n \"parser\": \"file\",\n \"find\": {\n \"serverPort=\": \"serverPort={{server.allocations.default.port}}\",\n \"serverIP=\": \"serverIP=0.0.0.0\",\n \"serverName=\": \"serverName={{server.environment.SERVER_NAME}}\",\n \"serverPassword=\": \"serverPassword={{server.environment.SERVER_PASSWORD}}\",\n \"showInPublicLobby=\": \"showInPublicLobby={{server.environment.SERVER_PUBLIC}}\",\n \"serverOwner=\": \"serverOwner={{server.environment.SERVER_OWNER}}\",\n \"worldname=\": \"worldname={{server.environment.WORLDNAME}}\",\n \"queryPort=\": \"queryPort={{server.environment.QUERY_PORT}}\",\n \"useSteamRelays=\": \"useSteamRelays={{server.environment.USE_STEAM_RELAYS}}\",\n \"welcomeMessage=\": \"welcomeMessage={{server.environment.WELCOME_MESSAGE}}\",\n \"recurringWelcomeMessage=\": \"recurringWelcomeMessage={{server.environment.RECURRING_WELCOME_MESSAGE}}\",\n \"pvpDisabled=\": \"pvpDisabled={{server.environment.PVP_DISABLED}}\"\n }\n }\n}",

"startup": "{\n \"done\":[\n \"*** Server Connected To STEAM *** \",\n \"to start the server ready to accept players!\"\n ]\n}",

survive_the_nights/egg-survive-the-nights.json

scootz · 2025-02-03T17:22:43Z

survive_the_nights/egg-pterodactyl-survive-the-nights.json

+            "user_viewable": true,
+            "user_editable": false,
+            "rules": "required|numeric",
+            "field_type": "text"


Suggested change

"field_type": "text"

"field_type": "text"

},

{

"name": "Use steam relays",

"description": "Use the steam relays to bypass firewalls.",

"env_variable": "USE_STEAM_RELAYS",

"default_value": "True",

"user_viewable": true,

"user_editable": true,

"rules": "required|string|in:True,False",

"field_type": "text"

},

{

"name": "Welcome message",

"description": "Message shown to new players.",

"env_variable": "WELCOME_MESSAGE",

"default_value": "Welcome to the server.",

"user_viewable": true,

"user_editable": true,

"rules": "string|nullable",

"field_type": "text"

},

{

"name": "Recurring welcome message",

"description": "Message to display for players who have previously joined the server.",

"env_variable": "RECURRING_WELCOME_MESSAGE",

"default_value": "Welcome to the server.",

"user_viewable": true,

"user_editable": true,

"rules": "string|nullable",

"field_type": "text"

},

{

"name": "PVP Disabled",

"description": "Allow or disallow PVP",

"env_variable": "PVP_DISABLED",

"default_value": "False",

"user_viewable": true,

"user_editable": true,

"rules": "required|string|in:True,False",

"field_type": "text"

???? Why that?

gOOvER · 2025-02-03T17:33:20Z

These are the changes I think should be added/changed.

You know, that this is the Pelican egg? Your requested changes are really senseless

scootz · 2025-02-03T17:37:10Z

@gOOvER the PR has both eggs (ptero and pelican) I edited both to make it easier to approve the changes. If this is wrong, i'm sorry :( This is my first attempt at doing this ever. Again sorry, if it causes a problem.

scootz

Again sorry if this was wrong of me to do, this egg was in limbo since august last year, I saw that someone else requested an egg for this game and @QuintenQVD0 mentioned no one tested it. I tested it and works.. with the exception of useSteamRelays. I had to set that to false to get it to work. I also added some variables. If this is wrong again, i don't know how many times I've said it, but I am sorry. purge my comments and forget about it. I'm still working on a couple that say "pending" that won't clear for me. I'm new at this. I honestly don't know what I'm doing I guess.

@gOOvER those suggested edits you ask why? I blame vscode. I changed QUERY_PORT manually to false user_editable. Maybe VSCODE formatted it to remove spaces on save and thus the change. Noted. I'll refrain from allowing changes like that in the future. Sorry.

QuintenQVD0 · 2025-02-03T20:01:15Z

Again sorry if this was wrong of me to do, this egg was in limbo since august last year, I saw that someone else requested an egg for this game and @QuintenQVD0 mentioned no one tested it. I tested it and works.. with the exception of useSteamRelays. I had to set that to false to get it to work. I also added some variables. If this is wrong again, i don't know how many times I've said it, but I am sorry. purge my comments and forget about it. I'm still working on a couple that say "pending" that won't clear for me. I'm new at this. I honestly don't know what I'm doing I guess.

@gOOvER those suggested edits you ask why? I blame vscode. I changed QUERY_PORT manually to false user_editable. Maybe VSCODE formatted it to remove spaces on save and thus the change. Noted. I'll refrain from allowing changes like that in the future. Sorry.

Thank you for your revieuw. But you did it a bit in an unusual way. If you want extra variables leave a comment on the last line of the egg with just a list of them. Don't add them as full json in a comment. And same for the parser. Mention like the key in the file with var it should match. It should not have full code in a comment.

Also just review the egg for the panel you have installed. Do not touch the other ones as the formats are different.

scootz · 2025-02-03T20:15:44Z

Thank you for your revieuw. But you did it a bit in an unusual way. If you want extra variables leave a comment on the last line of the egg with just a list of them. Don't add them as full json in a comment. And same for the parser. Mention like the key in the file with var it should match. It should not have full code in a comment.

Also just review the egg for the panel you have installed. Do not touch the other ones as the formats are different.

Mom always said I was unusual/different. So what else is new? lol. I do have both panels installed on two different computers, which is why I did both .json files. The only time I ever directly edited the file was to change my original change for the query_port back to false for user_editable which is where some of the spacing changes may have happened when I saved the file.

edit The only change I can't seem to get out of 'pending' is the exported_at line.

QuintenQVD0 added 2 commits August 11, 2024 14:13

Add: Survive The Nights

1f399d0

add to readme

185507d

scootz suggested changes Feb 3, 2025

View reviewed changes

survive_the_nights/egg-survive-the-nights.json Show resolved Hide resolved

scootz suggested changes Feb 3, 2025

View reviewed changes

survive_the_nights/egg-survive-the-nights.json Show resolved Hide resolved

scootz suggested changes Feb 3, 2025

View reviewed changes

survive_the_nights/egg-survive-the-nights.json Show resolved Hide resolved

scootz suggested changes Feb 3, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add: Survive The Nights #58

Add: Survive The Nights #58

QuintenQVD0 commented Aug 11, 2024

scootz commented Jan 31, 2025 •

edited

Loading

scootz commented Feb 3, 2025 •

edited

Loading

QuintenQVD0 commented Feb 3, 2025

QuintenQVD0 commented Feb 3, 2025

scootz left a comment

scootz Feb 3, 2025

scootz Feb 3, 2025

gOOvER Feb 3, 2025

gOOvER commented Feb 3, 2025 •

edited

Loading

scootz commented Feb 3, 2025

scootz left a comment

QuintenQVD0 commented Feb 3, 2025

scootz commented Feb 3, 2025 •

edited

Loading

		"files": "{\n \".\/Config\/ServerConfig.txt\": {\n \"parser\": \"file\",\n \"find\": {\n \"serverPort=\": \"serverPort={{server.allocations.default.port}}\",\n \"serverIP=\": \"serverIP=0.0.0.0\",\n \"serverName=\": \"serverName={{server.environment.SERVER_NAME}}\",\n \"serverPassword=\": \"serverPassword={{server.environment.SERVER_PASSWORD}}\",\n \"showInPublicLobby=\": \"showInPublicLobby={{server.environment.SERVER_PUBLIC}}\",\n \"serverOwner=\": \"serverOwner={{server.environment.SERVER_OWNER}}\",\n \"worldname=\": \"worldname={{server.environment.WORLDNAME}}\",\n \"queryPort=\": \"queryPort={{server.environment.QUERY_PORT}}\"\n }\n }\n}",
		"startup": "{\r\n \"done\":[\r\n \"* Server Connected To STEAM * \",\r\n \"to start the server ready to accept players!\"\r\n ]\r\n}",

-            "field_type": "text"
+            "field_type": "text"
+        },
+        {
+            "name": "Use steam relays",
+            "description": "Use the steam relays to bypass firewalls.",
+            "env_variable": "USE_STEAM_RELAYS",
+            "default_value": "True",
+            "user_viewable": true,
+            "user_editable": true,
+            "rules": "required|string|in:True,False",
+            "field_type": "text"
+        },
+        {
+            "name": "Welcome message",
+            "description": "Message shown to new players.",
+            "env_variable": "WELCOME_MESSAGE",
+            "default_value": "Welcome to the server.",
+            "user_viewable": true,
+            "user_editable": true,
+            "rules": "string|nullable",
+            "field_type": "text"
+        },
+        {
+            "name": "Recurring welcome message",
+            "description": "Message to display for players who have previously joined the server.",
+            "env_variable": "RECURRING_WELCOME_MESSAGE",
+            "default_value": "Welcome to the server.",
+            "user_viewable": true,
+            "user_editable": true,
+            "rules": "string|nullable",
+            "field_type": "text"
+        },
+        {
+            "name": "PVP Disabled",
+            "description": "Allow or disallow PVP",
+            "env_variable": "PVP_DISABLED",
+            "default_value": "False",
+            "user_viewable": true,
+            "user_editable": true,
+            "rules": "required|string|in:True,False",
+            "field_type": "text"

Add: Survive The Nights #58

Are you sure you want to change the base?

Add: Survive The Nights #58

Conversation

QuintenQVD0 commented Aug 11, 2024

Description

Checklist for all submissions

New egg Submissions

scootz commented Jan 31, 2025 • edited Loading

scootz commented Feb 3, 2025 • edited Loading

QuintenQVD0 commented Feb 3, 2025

QuintenQVD0 commented Feb 3, 2025

scootz left a comment

Choose a reason for hiding this comment

scootz Feb 3, 2025

Choose a reason for hiding this comment

scootz Feb 3, 2025

Choose a reason for hiding this comment

gOOvER Feb 3, 2025

Choose a reason for hiding this comment

gOOvER commented Feb 3, 2025 • edited Loading

scootz commented Feb 3, 2025

scootz left a comment

Choose a reason for hiding this comment

QuintenQVD0 commented Feb 3, 2025

scootz commented Feb 3, 2025 • edited Loading

scootz commented Jan 31, 2025 •

edited

Loading

scootz commented Feb 3, 2025 •

edited

Loading

gOOvER commented Feb 3, 2025 •

edited

Loading

scootz commented Feb 3, 2025 •

edited

Loading