-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove concept of 'word' #47
Comments
@Joxit 👍 or 👎 on this? I might have a look at doing it at some point when I have some time, but it will be a fairly noisy commit. |
I had a think about how this might work, before attempting this I think we should first focus on the
once this is done it should be possible to delete all single-word The main benefit of doing this refactor would be to clean up all the So if we have an idea of what we'd like the graph calls to look like to improve this then we can go ahead and start introducing new graph relationships to support them. Since relationships in the graph are cheap, we can safely build up a range of links, and also its fairly easy to monitor the use of graph relationships we'd like to deprecate (link At some point we can remove the |
This library has the concepts of
word
,phrase
andsection
I not sure if the
word
concept is required as it can be represented as a single tokenphrase
.In fact, I think there is duplication between
words
and single tokenphrases
right now.If possible, it would be nice to remove the concept of a
word
, which should help clean up the code.The text was updated successfully, but these errors were encountered: