pgsql back-end resource handling broken on PHP 8.1

[MarkMaldaba]

Since PHP 8.1, the postgres connection methods now return a PHP object rather than a resource.

From https://php.watch/versions/8.1/PgSQL-resource:

Prior to PHP 8.1, PostgreSQL extension returned and accepted database connections and results as resource objects. As part of PHP's resource to object migration, these resource types are migrated to class objects. All functions that returned a resource now return class objects instead, and all functions that accepted resource objects now accept the new class object, making this migration opaque with only the caveat being how a resource object is validated and closed.

In PEAR::DB, the DB_pgsql class is implemented on the assumption that the returned result is a PHP resource reference. In particular, the implementation type-casts the result to an integer which is used as an array index, which is no longer possible with the object implementation. In addition, there are checks using is_resource() which will fail on PHP 8, as this function only returns true for the resource implementation.

The class needs to be updated to handle both implementations, in order to support older PHP versions as well as continuing to run on PHP >= 8.1.

[schengawegga]

@MarkMaldaba Thank you. I´ll have a look at it.

[rossnick]

Any news on this ? we just hit this issue and rather keep pear::db than rewrite code that uses it for the moment.

[tmitanitky]

Any news on this ? we just hit this issue and rather keep pear::db than rewrite code that uses it for the moment.

I'm just a user and got a workaround for this problem. It is to replace
(int)$result to spl_object_id($result) or spl_object_hash($result) in pear\DB\pgsql.php.

[schengawegga]

I´m sorry, but i´m very busy at the moment.
@tmitanitky Can you provide a pull-request, please?

[tmitanitky]

Sure. I made a PR. Please review it when you are good and ready. Thanks.

[tmitanitky]

Sorry, I found some mistakes. I closed the PR and will try it again.

[rossnick]

@tmitanitky I was wondering what mistakes did you found that led you to remove your PR ?

[DanCld]

I have run into the very same problem today, so I have created this draft PR: #43

[schengawegga]

@DanCld Thanks for your PR. The sorucecode changes looks good to me. If anybody can approve the functionality, i will merge this PR into master branch.

[rossnick]

I tested the code by @DanCld on a local install where I previously had "Object of class PgSql\Result could not be converted to int" warnings. Now I don't and have proper result set. I am not an avid programmer, only a devops sysadmin I'll ask someone from my developer team to take a look.

[rossnick]

My dev team looked at the code, and it's in line with what was found when we first encountered the problem with pear and PHP >= 8.1. So look's good enough for me !