localhost:8080 loads forever

Expected Behavior

• pdoc3 at least loads up a the top-lv documentation on localhost

Actual Behavior

• localhost:8080 loads forever

Steps to Reproduce

1.run pdoc --template-dir .\docs\config\ --http : .\spotdl\ from the root of this repo

Additional info

• pdoc version: 0.9.2

• I essentially want the spotdl.defaults subpackage to be rendered, running pdoc -http : spotdl.defaults insteads loads up the installed version of spotdl (a modified personal copy of spotDL/spotify-downloader)

• It works just fine for every other package I've tried so far

Local CLI Output

PS D:\Projects\Code\spotdlRedesign> pdoc --template-dir .\docs\config\ .\spotdl\
d:\software\python3-9-1\lib\site-packages\pdoc\cli.py:532: UserWarning: Couldn't read PEP-224 variable docstrings from <Module 'spotdl'>: could not get source code
  modules = [pdoc.Module(module, docfilter=docfilter,
d:\software\python3-9-1\lib\site-packages\pdoc\__init__.py:708: UserWarning: Couldn't read PEP-224 variable docstrings from <Module 'spotdl.defaults'>: could not get source code
  m = Module(import_module(fullname),
Module spotdl
=============

Sub-modules
-----------
* spotdl.defaults
Traceback (most recent call last):
  File "d:\software\python3-9-1\lib\runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "d:\software\python3-9-1\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "D:\Software\Python3-9-1\Scripts\pdoc.exe\__main__.py", line 7, in <module>
  File "d:\software\python3-9-1\lib\site-packages\pdoc\cli.py", line 583, in main
    _generate_lunr_search(
  File "d:\software\python3-9-1\lib\site-packages\pdoc\cli.py", line 416, in _generate_lunr_search
    with _open_write_file(path.join(main_path, 'index.js')) as f:
  File "d:\software\python3-9-1\lib\ntpath.py", line 78, in join
    path = os.fspath(path)
TypeError: expected str, bytes or os.PathLike object, not NoneType

When I use the --http : flag, nothing happens, localhost:8080 just loads forever (a very long time)

[kernc]

The traceback above indicates the issue is in these lines:

pdoc/pdoc/cli.py

Lines 417 to 418 in c2c1320

	main_path = args.output_dir
	with _open_write_file(path.join(main_path, 'index.js')) as f:

However, args.output_dir is only set to default non-None when --html or --http:

pdoc/pdoc/cli.py

Lines 440 to 441 in c2c1320

	if (args.html or args.http) and not args.output_dir:
	args.output_dir = 'html'

I think the condition here should include --html and --http as adding JavaScript search makes little sense otherwise:

pdoc/pdoc/cli.py

Lines 582 to 585 in c2c1320

	lunr_config = pdoc._get_config(**template_config).get('lunr_search')
	if lunr_config is not None:
	_generate_lunr_search(
	modules, lunr_config.get("index_docstrings", True), template_config)

All of this is likely unrelated to the stalled page load you're seeing with --http :.

I'm not going to lie, I didn't understand one bit of what you said. Unlike you, I don't have an overall understanding of the software structure so your going to have to simplify what your saying.

[kernc]

251d61a should fix the traceback you quoted. Thanks.

--http : stalling would be great to pinpoint. We don't have any infinite loops I think. Might any of the imported packages be waiting for stdin input?

instead loads up the installed version of spotdl

We do a bit of magic to import the specified module. We maybe chdir, then defer to importlib.import_module():

pdoc/pdoc/__init__.py

Lines 198 to 228 in 251d61a

	def import_module(module: Union[str, ModuleType],
	*, reload: bool = False) -> ModuleType:
	"""
	Return module object matching `module` specification (either a python
	module path or a filesystem path to file/directory).
	"""
	@contextmanager
	def _module_path(module):
	from os.path import abspath, dirname, isfile, isdir, split
	path = '_pdoc_dummy_nonexistent'
	module_name = inspect.getmodulename(module)
	if isdir(module):
	path, module = split(abspath(module))
	elif isfile(module) and module_name:
	path, module = dirname(abspath(module)), module_name
	try:
	sys.path.insert(0, path)
	yield module
	finally:
	sys.path.remove(path)
	if isinstance(module, Module):
	module = module.obj
	if isinstance(module, str):
	with _module_path(module) as module_path:
	try:
	module = importlib.import_module(module_path)
	except Exception as e:
	raise ImportError(f'Error importing {module!r}: {e.__class__.__name__}: {e}')
	assert inspect.ismodule(module)

Might any of the imported packages be waiting for stdin input?

Nope. That's come up before, so I checked. I'll retry today