You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 9, 2017. It is now read-only.
Back in the old days (before I was involved) the spatial_adapter was actually two plugins, one for PostgreSQL and one for MySQL. Then it was merged a while before I took over maintenance. However, the merged plugin has some serious dependency problems that cause me to question that decision.
I can't add the necessary gem dependencies (the pg or mysql gems) because few (or none) of the plugin's users will want to install both of them.
Adding more database adapters only makes the problem worse.
Despite a little bit of common code, I'm inclined to split into postgresql_spatial_adapter and mysql_spatial_adapter once more. Suggestions for reducing duplication, or alternate solutions, are welcome.
The text was updated successfully, but these errors were encountered:
I think that probably makes sense for most people. We currently support multiple databases, so we'd have to install more plugins with this setup, but I think you're right that it solves some issues and is cleaner dependency-wise.
I would suggest considering a parent gem that all the adapters are dependent on, not just to reduce code duplication, but also to present a single place where we can document the API, and coordinate API changes.
Back in the old days (before I was involved) the spatial_adapter was actually two plugins, one for PostgreSQL and one for MySQL. Then it was merged a while before I took over maintenance. However, the merged plugin has some serious dependency problems that cause me to question that decision.
Despite a little bit of common code, I'm inclined to split into postgresql_spatial_adapter and mysql_spatial_adapter once more. Suggestions for reducing duplication, or alternate solutions, are welcome.
The text was updated successfully, but these errors were encountered: