-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
includeAllParams not working #268
Comments
Same here. I both configured this on provider and hook levels but it does not include the params does not exists in the config map. I am generating some filter inputs based on some remote data. I have no idea about the names and count. As a workaround, I am building a second param config on the fly and merging it with the existing one: const ConfigForRemote = remoteData.attributes.reduce((acc, attr) => {
return { ...acc, [attr.code]: withDefault(StringParam, undefined) };
}, {} as any);
const [params, setParams] = useQueryParams<typeof MyParamConfig>({ ...MyParamConfig, ...ConfigForRemote }); The above is working so far. |
Can confirm, this is not working as intended. Parameters that are not included in the configuration are getting clobbered. This is specifically happening with |
Same with me. Moving away from this library due to lack of maintenance, and lack of time to invest in it, unfortunately :") |
I'm using this lib together with next-query-params.
I have a QueryParamConfigMap which I pass to
useQueryParams(queryParamConfigMap, { includeAllParams: true })
The return value however does not include query params that are not included in the config.
The text was updated successfully, but these errors were encountered: