enable dependabot and golangci-lint

Author: emilien-puget

.github/dependabot.yml

@@ -0,0 +1,6 @@
+version: 2
+updates:
+  - package-ecosystem: "gomod"
+    directory: "/"
+    schedule:
+      interval: "weekly"

.github/workflows/build.yaml

@@ -9,6 +9,21 @@ on:
       - main
 
 jobs:
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout scm
+        uses: actions/checkout@v3
+
+      - name: Set up Go
+        uses: actions/setup-go@v4
+        with:
+          go-version-file: go.mod
+
+      - name: Lint
+        uses: golangci/golangci-lint-action@v4
+        with:
+          version: v1.61.0
   build:
     name: Build
     runs-on: ubuntu-latest

.golangci.yml

@@ -0,0 +1,27 @@
+run:
+  timeout: "10m"
+linters:
+  disable-all: true
+  enable:
+    # Format
+    - "gofumpt" # Gofumpt checks whether code was gofumpt-ed. Which is a superset of gofmt that handles some cases that gofmt missed.
+    - "gci" # Gci controls Go package import order and makes it always deterministic.
+    - "asciicheck" # Checks that all code identifiers does not have non-ASCII symbols in the name.
+    - "bidichk" # Checks for dangerous unicode character sequences.
+    # Error
+    - "errcheck"
+    # Simplify
+    - "gosimple"
+    - "govet"
+    - "ineffassign"
+    - "staticcheck"
+    - "unused"
+linters-settings:
+  gci:
+    sections:
+      - standard
+      - default
+      - localmodule
+      - blank
+      - dot
+      - alias

Makefile

@@ -0,0 +1,15 @@
+all: gofumpt import lint
+
+init:
+	go install mvdan.cc/gofumpt@v0.7.0
+	go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.61.0
+	go install github.com/daixiang0/gci@v0.13.5
+
+lint:
+	golangci-lint run ./...
+
+gofumpt:
+	gofumpt -l -w .
+
+import:
+	gci write --skip-generated -s standard -s default -s localmodule -s blank -s dot -s alias .

errors/error_utilities_test.go

@@ -4,9 +4,10 @@
 package errors
 
 import (
-	"github.com/stretchr/testify/require"
 	"net/http"
 	"testing"
+
+	"github.com/stretchr/testify/require"
 )
 
 // Helper function to create a mock ValidationError

errors/parameter_errors.go

@@ -5,9 +5,11 @@ import (
 	"net/url"
 	"strings"
 
-	"github.com/pb33f/libopenapi-validator/helpers"
 	"github.com/pb33f/libopenapi/datamodel/high/base"
+
 	v3 "github.com/pb33f/libopenapi/datamodel/high/v3"
+
+	"github.com/pb33f/libopenapi-validator/helpers"
 )
 
 func IncorrectFormEncoding(param *v3.Parameter, qp *helpers.QueryParam, i int) *ValidationError {
@@ -133,7 +135,8 @@ func IncorrectHeaderParamEnum(param *v3.Parameter, ef string, sch *base.Schema)
 }
 
 func IncorrectQueryParamArrayBoolean(
-	param *v3.Parameter, item string, sch *base.Schema, itemsSchema *base.Schema) *ValidationError {
+	param *v3.Parameter, item string, sch *base.Schema, itemsSchema *base.Schema,
+) *ValidationError {
 	return &ValidationError{
 		ValidationType:    helpers.ParameterValidation,
 		ValidationSubType: helpers.ParameterValidationQuery,
@@ -148,7 +151,8 @@ func IncorrectQueryParamArrayBoolean(
 }
 
 func IncorrectCookieParamArrayBoolean(
-	param *v3.Parameter, item string, sch *base.Schema, itemsSchema *base.Schema) *ValidationError {
+	param *v3.Parameter, item string, sch *base.Schema, itemsSchema *base.Schema,
+) *ValidationError {
 	return &ValidationError{
 		ValidationType:    helpers.ParameterValidation,
 		ValidationSubType: helpers.ParameterValidationCookie,
@@ -163,7 +167,8 @@ func IncorrectCookieParamArrayBoolean(
 }
 
 func IncorrectQueryParamArrayNumber(
-	param *v3.Parameter, item string, sch *base.Schema, itemsSchema *base.Schema) *ValidationError {
+	param *v3.Parameter, item string, sch *base.Schema, itemsSchema *base.Schema,
+) *ValidationError {
 	return &ValidationError{
 		ValidationType:    helpers.ParameterValidation,
 		ValidationSubType: helpers.ParameterValidationQuery,
@@ -178,7 +183,8 @@ func IncorrectQueryParamArrayNumber(
 }
 
 func IncorrectCookieParamArrayNumber(
-	param *v3.Parameter, item string, sch *base.Schema, itemsSchema *base.Schema) *ValidationError {
+	param *v3.Parameter, item string, sch *base.Schema, itemsSchema *base.Schema,
+) *ValidationError {
 	return &ValidationError{
 		ValidationType:    helpers.ParameterValidation,
 		ValidationSubType: helpers.ParameterValidationCookie,
@@ -364,7 +370,8 @@ func IncorrectCookieParamEnum(param *v3.Parameter, ef string, sch *base.Schema)
 }
 
 func IncorrectHeaderParamArrayBoolean(
-	param *v3.Parameter, item string, sch *base.Schema, itemsSchema *base.Schema) *ValidationError {
+	param *v3.Parameter, item string, sch *base.Schema, itemsSchema *base.Schema,
+) *ValidationError {
 	return &ValidationError{
 		ValidationType:    helpers.ParameterValidation,
 		ValidationSubType: helpers.ParameterValidationHeader,
@@ -379,7 +386,8 @@ func IncorrectHeaderParamArrayBoolean(
 }
 
 func IncorrectHeaderParamArrayNumber(
-	param *v3.Parameter, item string, sch *base.Schema, itemsSchema *base.Schema) *ValidationError {
+	param *v3.Parameter, item string, sch *base.Schema, itemsSchema *base.Schema,
+) *ValidationError {
 	return &ValidationError{
 		ValidationType:    helpers.ParameterValidation,
 		ValidationSubType: helpers.ParameterValidationHeader,
@@ -441,7 +449,8 @@ func IncorrectPathParamNumber(param *v3.Parameter, item string, sch *base.Schema
 }
 
 func IncorrectPathParamArrayNumber(
-	param *v3.Parameter, item string, sch *base.Schema, itemsSchema *base.Schema) *ValidationError {
+	param *v3.Parameter, item string, sch *base.Schema, itemsSchema *base.Schema,
+) *ValidationError {
 	return &ValidationError{
 		ValidationType:    helpers.ParameterValidation,
 		ValidationSubType: helpers.ParameterValidationPath,
@@ -456,7 +465,8 @@ func IncorrectPathParamArrayNumber(
 }
 
 func IncorrectPathParamArrayBoolean(
-	param *v3.Parameter, item string, sch *base.Schema, itemsSchema *base.Schema) *ValidationError {
+	param *v3.Parameter, item string, sch *base.Schema, itemsSchema *base.Schema,
+) *ValidationError {
 	return &ValidationError{
 		ValidationType:    helpers.ParameterValidation,
 		ValidationSubType: helpers.ParameterValidationPath,