Skip to content

Commit d35bebd

Browse files
Dmytro Panchenkodzmitrybitsiutski
Dmytro Panchenko
authored and
dzmitrybitsiutski
committed
SUPPORT-84787 Remove create() method from Paysera_WalletApi_Entity_ClientPermissionsToWallet
1 parent 43c0870 commit d35bebd

File tree

3 files changed

+24
-32
lines changed

3 files changed

+24
-32
lines changed

‎src/Paysera/WalletApi/Entity/ClientPermissionsToWallet.php‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,6 @@ class Paysera_WalletApi_Entity_ClientPermissionsToWallet
1515
*/
1616
private $scopes = [];
1717

18-
/**
19-
* @return self
20-
*/
21-
public static function create()
22-
{
23-
return new self();
24-
}
25-
2618
/**
2719
* @param Paysera_WalletApi_Entity_Wallet $wallet
2820
* @return self

‎src/Paysera/WalletApi/Mapper.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2429,7 +2429,7 @@ public function decodeClientPermissionsToWallets(array $clientPermissionsToWalle
24292429
*/
24302430
public function decodeClientPermissionsToWallet(array $clientPermissionsToWallet)
24312431
{
2432-
return Paysera_WalletApi_Entity_ClientPermissionsToWallet::create()
2432+
return (new Paysera_WalletApi_Entity_ClientPermissionsToWallet())
24332433
->setWallet($this->decodeWallet($clientPermissionsToWallet['wallet']))
24342434
->setScopes($clientPermissionsToWallet['scopes'])
24352435
;

‎tests/Paysera/WalletApi/MapperTest.php‎

Lines changed: 23 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -334,10 +334,10 @@ public function testDecodeClientDataProvider()
334334
->setMainProjectId(1)
335335
->setPermissionsToWallets(
336336
[
337-
Paysera_WalletApi_Entity_ClientPermissionsToWallet::create()
337+
(new Paysera_WalletApi_Entity_ClientPermissionsToWallet())
338338
->setWallet($this->createWallet(1, 1, $this->createAccount('EVP1')))
339339
->setScopes(['balance']),
340-
Paysera_WalletApi_Entity_ClientPermissionsToWallet::create()
340+
(new Paysera_WalletApi_Entity_ClientPermissionsToWallet())
341341
->setWallet($this->createWallet(2, 2, $this->createAccount('EVP2')))
342342
->setScopes(['statements']),
343343
]
@@ -422,10 +422,10 @@ public function testDecodeClientDataProvider()
422422
->setMainProjectId(1)
423423
->setPermissionsToWallets(
424424
[
425-
Paysera_WalletApi_Entity_ClientPermissionsToWallet::create()
425+
(new Paysera_WalletApi_Entity_ClientPermissionsToWallet())
426426
->setWallet($this->createWallet(1, 1, $this->createAccount('EVP1')))
427427
->setScopes(['balance']),
428-
Paysera_WalletApi_Entity_ClientPermissionsToWallet::create()
428+
(new Paysera_WalletApi_Entity_ClientPermissionsToWallet())
429429
->setWallet($this->createWallet(2, 2, $this->createAccount('EVP2')))
430430
->setScopes(['statements']),
431431
]
@@ -517,10 +517,10 @@ public function testDecodeClientDataProvider()
517517
->setMainProjectId(1)
518518
->setPermissionsToWallets(
519519
[
520-
Paysera_WalletApi_Entity_ClientPermissionsToWallet::create()
520+
(new Paysera_WalletApi_Entity_ClientPermissionsToWallet())
521521
->setWallet($this->createWallet(1, 1, $this->createAccount('EVP1')))
522522
->setScopes(['balance']),
523-
Paysera_WalletApi_Entity_ClientPermissionsToWallet::create()
523+
(new Paysera_WalletApi_Entity_ClientPermissionsToWallet())
524524
->setWallet($this->createWallet(2, 2, $this->createAccount('EVP2')))
525525
->setScopes(['statements']),
526526
]
@@ -631,10 +631,10 @@ public function testEncodeClientDataProvider()
631631
)
632632
->setPermissionsToWallets(
633633
[
634-
Paysera_WalletApi_Entity_ClientPermissionsToWallet::create()
634+
(new Paysera_WalletApi_Entity_ClientPermissionsToWallet())
635635
->setWallet($this->createWallet(1, 1, $this->createAccount('EVP1')))
636636
->setScopes(['balance']),
637-
Paysera_WalletApi_Entity_ClientPermissionsToWallet::create()
637+
(new Paysera_WalletApi_Entity_ClientPermissionsToWallet())
638638
->setWallet($this->createWallet(2, 2, $this->createAccount('EVP2')))
639639
->setScopes(['statements']),
640640
]
@@ -685,10 +685,10 @@ public function testEncodeClientDataProvider()
685685
)
686686
->setPermissionsToWallets(
687687
[
688-
Paysera_WalletApi_Entity_ClientPermissionsToWallet::create()
688+
(new Paysera_WalletApi_Entity_ClientPermissionsToWallet())
689689
->setWallet($this->createWallet(1, 1, $this->createAccount('EVP1')))
690690
->setScopes(['balance']),
691-
Paysera_WalletApi_Entity_ClientPermissionsToWallet::create()
691+
(new Paysera_WalletApi_Entity_ClientPermissionsToWallet())
692692
->setWallet($this->createWallet(2, 2, $this->createAccount('EVP2')))
693693
->setScopes(['statements']),
694694
]
@@ -790,7 +790,7 @@ public function decodeClientPermissionsToWalletDataProvider()
790790
],
791791
'scopes' => [],
792792
],
793-
'expectedPermission' => Paysera_WalletApi_Entity_ClientPermissionsToWallet::create()
793+
'expectedPermission' => (new Paysera_WalletApi_Entity_ClientPermissionsToWallet())
794794
->setWallet($this->getWallet(1, $this->getAccount('EVP1')))
795795
->setScopes([]),
796796
'isBalanceGranted' => false,
@@ -809,7 +809,7 @@ public function decodeClientPermissionsToWalletDataProvider()
809809
'balance'
810810
],
811811
],
812-
'expectedPermission' => Paysera_WalletApi_Entity_ClientPermissionsToWallet::create()
812+
'expectedPermission' => (new Paysera_WalletApi_Entity_ClientPermissionsToWallet())
813813
->setWallet($this->getWallet(2, $this->getAccount('EVP2')))
814814
->setScopes([Paysera_WalletApi_OAuth_Consumer::SCOPE_BALANCE]),
815815
'isBalanceGranted' => true,
@@ -828,7 +828,7 @@ public function decodeClientPermissionsToWalletDataProvider()
828828
'statements'
829829
],
830830
],
831-
'expectedPermission' => Paysera_WalletApi_Entity_ClientPermissionsToWallet::create()
831+
'expectedPermission' => (new Paysera_WalletApi_Entity_ClientPermissionsToWallet())
832832
->setWallet($this->getWallet(3, $this->getAccount('EVP3')))
833833
->setScopes([Paysera_WalletApi_OAuth_Consumer::SCOPE_STATEMENTS]),
834834
'isBalanceGranted' => false,
@@ -848,7 +848,7 @@ public function decodeClientPermissionsToWalletDataProvider()
848848
'statements',
849849
],
850850
],
851-
'expectedPermission' => Paysera_WalletApi_Entity_ClientPermissionsToWallet::create()
851+
'expectedPermission' => (new Paysera_WalletApi_Entity_ClientPermissionsToWallet())
852852
->setWallet($this->getWallet(4, $this->getAccount('EVP4')))
853853
->setScopes([
854854
Paysera_WalletApi_OAuth_Consumer::SCOPE_BALANCE,
@@ -870,7 +870,7 @@ public function decodeClientPermissionsToWalletDataProvider()
870870
'unknown'
871871
],
872872
],
873-
'expectedPermission' => Paysera_WalletApi_Entity_ClientPermissionsToWallet::create()
873+
'expectedPermission' => (new Paysera_WalletApi_Entity_ClientPermissionsToWallet())
874874
->setWallet($this->getWallet(5, $this->getAccount('EVP5')))
875875
->setScopes([
876876
'unknown'
@@ -885,30 +885,30 @@ public function encodeClientPermissionsToWalletDataProvider()
885885
{
886886
return [
887887
'Case 1 Expect empty wallet exception' => [
888-
'input' => Paysera_WalletApi_Entity_ClientPermissionsToWallet::create()
888+
'input' => (new Paysera_WalletApi_Entity_ClientPermissionsToWallet())
889889
->setScopes([]),
890890
'expected' => new Paysera_WalletApi_Exception_LogicException('Wallet must be provided'),
891891
],
892892
'Case 2 Expect empty wallet ID exception' => [
893-
'input' => Paysera_WalletApi_Entity_ClientPermissionsToWallet::create()
893+
'input' => (new Paysera_WalletApi_Entity_ClientPermissionsToWallet())
894894
->setWallet($this->getWallet(null, null))
895895
->setScopes([]),
896896
'expected' => new Paysera_WalletApi_Exception_LogicException('Wallet ID must be provided'),
897897
],
898898
'Case 3 Expect empty account exception' => [
899-
'input' => Paysera_WalletApi_Entity_ClientPermissionsToWallet::create()
899+
'input' => (new Paysera_WalletApi_Entity_ClientPermissionsToWallet())
900900
->setWallet($this->getWallet(1, null))
901901
->setScopes([]),
902902
'expected' => new Paysera_WalletApi_Exception_LogicException('Account must be provided'),
903903
],
904904
'Case 4 Expect empty account number exception' => [
905-
'input' => Paysera_WalletApi_Entity_ClientPermissionsToWallet::create()
905+
'input' => (new Paysera_WalletApi_Entity_ClientPermissionsToWallet())
906906
->setWallet($this->getWallet(1, $this->getAccount(null)))
907907
->setScopes([]),
908908
'expected' => new Paysera_WalletApi_Exception_LogicException('Account number must be provided'),
909909
],
910910
'Case 3 No scopes' => [
911-
'input' => Paysera_WalletApi_Entity_ClientPermissionsToWallet::create()
911+
'input' => (new Paysera_WalletApi_Entity_ClientPermissionsToWallet())
912912
->setWallet($this->getWallet(2, $this->getAccount('EVP2')))
913913
->setScopes([]),
914914
'expected' => [
@@ -918,7 +918,7 @@ public function encodeClientPermissionsToWalletDataProvider()
918918
],
919919
],
920920
'Case 4 Balance only' => [
921-
'input' => Paysera_WalletApi_Entity_ClientPermissionsToWallet::create()
921+
'input' => (new Paysera_WalletApi_Entity_ClientPermissionsToWallet())
922922
->setWallet($this->getWallet(3, $this->getAccount('EVP3')))
923923
->setScopes([Paysera_WalletApi_OAuth_Consumer::SCOPE_BALANCE]),
924924
'expected' => [
@@ -928,7 +928,7 @@ public function encodeClientPermissionsToWalletDataProvider()
928928
],
929929
],
930930
'Case 5 Statements only' => [
931-
'input' => Paysera_WalletApi_Entity_ClientPermissionsToWallet::create()
931+
'input' => (new Paysera_WalletApi_Entity_ClientPermissionsToWallet())
932932
->setWallet($this->getWallet(4, $this->getAccount('EVP4')))
933933
->setScopes([Paysera_WalletApi_OAuth_Consumer::SCOPE_STATEMENTS]),
934934
'expected' => [
@@ -938,7 +938,7 @@ public function encodeClientPermissionsToWalletDataProvider()
938938
],
939939
],
940940
'Case 6 Both balance and statements' => [
941-
'input' => Paysera_WalletApi_Entity_ClientPermissionsToWallet::create()
941+
'input' => (new Paysera_WalletApi_Entity_ClientPermissionsToWallet())
942942
->setWallet($this->getWallet(5, $this->getAccount('EVP5')))
943943
->setScopes([
944944
Paysera_WalletApi_OAuth_Consumer::SCOPE_BALANCE,

0 commit comments

Comments
 (0)