Add ser/deser tests for ReceiverSessionEvent

This commit adds test coverage for the full
serialization/deserialization round trip for each receiver session
event.

Author: arminsabouri

payjoin/src/receive/v1/mod.rs

@@ -807,7 +807,26 @@ pub(crate) mod test {
         UncheckedProposal { psbt: PARSED_ORIGINAL_PSBT.clone(), params }
     }
 
-    fn wants_outputs_from_test_vector(proposal: UncheckedProposal) -> WantsOutputs {
+    pub(crate) fn maybe_inputs_owned_from_test_vector() -> MaybeInputsOwned {
+        let proposal = unchecked_proposal_from_test_vector();
+        proposal
+            .check_broadcast_suitability(None, |_| Ok(true))
+            .expect("Broadcast suitability check should not fail")
+    }
+
+    pub(crate) fn maybe_inputs_seen_from_test_vector() -> MaybeInputsSeen {
+        let maybe_inputs_owned = maybe_inputs_owned_from_test_vector();
+        maybe_inputs_owned.check_inputs_not_owned(|_| Ok(false)).expect("No inputs should be owned")
+    }
+
+    pub(crate) fn outputs_unknown_from_test_vector() -> OutputsUnknown {
+        let maybe_inputs_seen = maybe_inputs_seen_from_test_vector();
+        maybe_inputs_seen
+            .check_no_inputs_seen_before(|_| Ok(false))
+            .expect("No inputs should be seen before")
+    }
+
+    pub(crate) fn wants_outputs_from_test_vector(proposal: UncheckedProposal) -> WantsOutputs {
         proposal
             .assume_interactive_receiver()
             .check_inputs_not_owned(|_| Ok(false))
@@ -825,10 +844,25 @@ pub(crate) mod test {
             .expect("Receiver output should be identified")
     }
 
-    fn provisional_proposal_from_test_vector(proposal: UncheckedProposal) -> ProvisionalProposal {
+    pub(crate) fn wants_inputs_from_test_vector() -> WantsInputs {
+        let proposal = unchecked_proposal_from_test_vector();
+        wants_outputs_from_test_vector(proposal).commit_outputs()
+    }
+
+    pub(crate) fn provisional_proposal_from_test_vector(
+        proposal: UncheckedProposal,
+    ) -> ProvisionalProposal {
         wants_outputs_from_test_vector(proposal).commit_outputs().commit_inputs()
     }
 
+    pub(crate) fn payjoin_proposal_from_test_vector(
+        proposal: UncheckedProposal,
+    ) -> PayjoinProposal {
+        provisional_proposal_from_test_vector(proposal)
+            .finalize_proposal(|_| Ok(PARSED_ORIGINAL_PSBT.clone()), None, None)
+            .expect("finalize_proposal should not fail")
+    }
+
     #[test]
     fn is_output_substitution_disabled() {
         let mut proposal = unchecked_proposal_from_test_vector();

payjoin/src/receive/v2/persist.rs

@@ -48,3 +48,41 @@ pub enum SessionEvent {
     /// b/c its a terminal state and there is nothing to replay. So serialization will be lossy and that is fine.
     SessionInvalid(String),
 }
+
+#[cfg(test)]
+mod tests {
+    use super::*;
+    use crate::receive::v1::test::{
+        maybe_inputs_owned_from_test_vector, maybe_inputs_seen_from_test_vector,
+        outputs_unknown_from_test_vector, payjoin_proposal_from_test_vector,
+        provisional_proposal_from_test_vector, unchecked_proposal_from_test_vector,
+        wants_inputs_from_test_vector, wants_outputs_from_test_vector,
+    };
+    use crate::receive::v2::test::SHARED_CONTEXT;
+
+    #[test]
+    fn test_session_event_serialization_roundtrip() {
+        let unchecked_proposal = unchecked_proposal_from_test_vector();
+        let test_cases = vec![
+            SessionEvent::Created(SHARED_CONTEXT.clone()),
+            SessionEvent::UncheckedProposal(unchecked_proposal.clone()),
+            SessionEvent::MaybeInputsOwned(maybe_inputs_owned_from_test_vector()),
+            SessionEvent::MaybeInputsSeen(maybe_inputs_seen_from_test_vector()),
+            SessionEvent::OutputsUnknown(outputs_unknown_from_test_vector()),
+            SessionEvent::WantsOutputs(wants_outputs_from_test_vector(unchecked_proposal.clone())),
+            SessionEvent::WantsInputs(wants_inputs_from_test_vector()),
+            SessionEvent::ProvisionalProposal(provisional_proposal_from_test_vector(
+                unchecked_proposal.clone(),
+            )),
+            SessionEvent::PayjoinProposal(payjoin_proposal_from_test_vector(
+                unchecked_proposal.clone(),
+            )),
+        ];
+        for event in test_cases {
+            let serialized = serde_json::to_string(&event).expect("Serialization should not fail");
+            let deserialized: SessionEvent =
+                serde_json::from_str(&serialized).expect("Deserialization should not fail");
+            assert_eq!(event, deserialized);
+        }
+    }
+}