Skip to content

Compass components feedback followup #12108

@kmcfaul

Description

@kmcfaul

Follow up to #12093

  • CompassMainHeader - update the flex to below & conditionally render both, or update core + react to contain styled semantic wrapping divs
 <FlexItem grow={{ default: 'grow' }}>{title}</FlexItem>
 <FlexItem align={{ default: 'alightRight' }}>{toolbar}</FlexItem>
  • Decide on whether optional elements should conditionally render their associated div or the div should remain even without content (tied into whether the div is necessary for the layout). I feel we've got back and forth on this pattern of conditional rendering and were burned a little when it came to animations needing divs to render even when hidden/empty?

  • Second pass on hardcoded classes (compass__logo iirc wasn't a functional class in core is why that's still hardcoded).

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    Status

    Needs triage

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions