-
Notifications
You must be signed in to change notification settings - Fork 373
Open
Labels
Description
Follow up to #12093
- CompassMainHeader - update the flex to below & conditionally render both, or update core + react to contain styled semantic wrapping divs
<FlexItem grow={{ default: 'grow' }}>{title}</FlexItem>
<FlexItem align={{ default: 'alightRight' }}>{toolbar}</FlexItem>
-
Decide on whether optional elements should conditionally render their associated div or the div should remain even without content (tied into whether the div is necessary for the layout). I feel we've got back and forth on this pattern of conditional rendering and were burned a little when it came to animations needing divs to render even when hidden/empty?
-
Second pass on hardcoded classes (compass__logo iirc wasn't a functional class in core is why that's still hardcoded).
Metadata
Metadata
Assignees
Labels
Type
Projects
Status
Needs triage