Add new dependencies and enhance OAuth authorization flow with PKCE s… #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakshith-ravi
requested changes
Oct 14, 2025
Comment on lines
+106
to
+117
| let login = "http://localhost:3001/auth/sign-in" | ||
| .parse() | ||
| .expect("cannot find login url"); | ||
|
|
||
| AppResponse::builder() | ||
| .body(OAuthAuthorizeResponse) | ||
| .headers(OAuthAuthorizeResponseHeaders { | ||
| redirect_url: login, | ||
| }) | ||
| .status_code(StatusCode::FOUND) | ||
| .build() | ||
| .into_result() |
Contributor
There was a problem hiding this comment.
Assume the user is logged in. If the user is not logged in, throw an error. This request will be sent by the frontend. So the frontend will be responsible for taking care of login and what not
|
|
||
| pub fn decode_token(token: &str, secret: &str) -> Result<AuthClaims, jsonwebtoken::errors::Error> { | ||
| info!("Decoding token: {}", token); | ||
| match decode::<AuthClaims>( |
Contributor
There was a problem hiding this comment.
I'd like to manually take care of exp.
| axum-typed-websockets = { workspace = true, features = ["default"] } | ||
| base32 = { workspace = true, features = [] } | ||
| base64 = { workspace = true, features = ["default"] } | ||
| chrono = { workspace = true, features = ["default", "serde"] } |
Contributor
There was a problem hiding this comment.
No chrono. Use the time crate instead
| pub client_id: String, | ||
| /// The redirect URI of the third-party app | ||
| #[serde(default, skip_serializing_if = "Option::is_none")] | ||
| #[serde(default, skip_serializing_if = "Option::is_none", rename = "redirect_uri")] |
Contributor
There was a problem hiding this comment.
You're renaming to the same name?
| pub scope: String, | ||
| /// The state of the request, if any | ||
| pub state: Option<String>, | ||
| #[serde(rename = "code_challenge")] |
| #[serde(rename = "code_challenge")] | ||
| /// The hashed value of a code challenge (as per PKCE) | ||
| pub code_challenge: String, | ||
| #[serde(rename = "code_challenge_method")] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.