Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: serde StaticSchema #1126

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Jan 20, 2025

Fixes #XXXX.

Description

This has been opened as a separate PR from #1100 to explore the cause of ingestion failure due to timeouts in cluster setup


This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@de-sh de-sh marked this pull request as draft January 20, 2025 17:51
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12873408627

Details

  • 0 of 63 (0.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 12.711%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/handlers/http/modal/ingest/ingestor_logstream.rs 0 7 0.0%
src/handlers/http/modal/query/querier_logstream.rs 0 9 0.0%
src/handlers/http/cluster/mod.rs 0 10 0.0%
src/handlers/http/modal/utils/logstream_utils.rs 0 18 0.0%
src/handlers/http/logstream.rs 0 19 0.0%
Totals Coverage Status
Change from base Build 12855418418: -0.003%
Covered Lines: 2459
Relevant Lines: 19346

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants