-
-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use debug_assertions
instead of custom feature
#1104
Conversation
Pull Request Test Coverage Report for Build 12863585408Details
💛 - Coveralls |
Does this mean the Also can you confirm we don't need a change in the Dockerfile here: https://github.com/parseablehq/parseable/blob/main/Dockerfile.debug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a comment
@@ -23,7 +23,7 @@ LABEL org.opencontainers.image.licenses="AGPL-3.0" | |||
|
|||
WORKDIR /parseable | |||
COPY . . | |||
RUN cargo build --features debug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have made that change @nitisht
Fixes #XXXX.
Description
We don't need a custom feature, https://doc.rust-lang.org/reference/conditional-compilation.html#debug_assertions
This PR has: