Skip to content

Commit 835e9b9

Browse files
committed
-v flag to clean up volumes when stopping containers. Remove the error suppression in favor of proper error handling.
1 parent ce2fca0 commit 835e9b9

File tree

2 files changed

+18
-12
lines changed

2 files changed

+18
-12
lines changed

.github/workflows/coverage.yaml

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
coverage:
1515
runs-on: ubuntu-latest
1616
steps:
17-
- uses: actions/checkout@v2
17+
- uses: actions/checkout@v4
1818
- uses: dtolnay/rust-toolchain@stable
1919
with:
2020
components: clippy
@@ -27,9 +27,15 @@ jobs:
2727
with:
2828
tool: cargo-hack, cargo-llvm-cov, nextest
2929

30-
- name: Install dependencies
31-
run: sudo apt-get install -y libsasl2-dev || echo "Skipping libsasl2-dev installation"
32-
continue-on-error: true
30+
- name: Install System Dependencies
31+
run: |
32+
sudo apt-get update
33+
sudo apt-get install -y \
34+
libsasl2-dev \
35+
libssl-dev \
36+
pkg-config \
37+
build-essential
38+
if: runner.os == 'Linux'
3339

3440
- name: Check with clippy
3541
run: cargo hack clippy --verbose --each-feature --no-dev-deps -- -D warnings

.github/workflows/integration-test.yaml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,45 +14,45 @@ jobs:
1414
runs-on: ubuntu-latest
1515
steps:
1616
- name: Checkout
17-
uses: actions/checkout@v3
17+
uses: actions/checkout@v4
1818
- name: Start compose
1919
run: docker compose -f docker-compose-test.yaml up --build --exit-code-from quest
2020
- name: Stop compose
2121
if: always()
22-
run: docker compose -f docker-compose-test.yaml down
22+
run: docker compose -f docker-compose-test.yaml down -v
2323

2424
docker-compose-distributed-test:
2525
name: Quest Smoke and Load Tests for Distributed deployments
2626
runs-on: ubuntu-latest
2727
steps:
2828
- name: Checkout
29-
uses: actions/checkout@v3
29+
uses: actions/checkout@v4
3030
- name: Start compose
3131
run: docker compose -f docker-compose-distributed-test.yaml up --build --exit-code-from quest
3232
- name: Stop compose
3333
if: always()
34-
run: docker compose -f docker-compose-distributed-test.yaml down
34+
run: docker compose -f docker-compose-distributed-test.yaml down -v
3535

3636
docker-compose-test-with-kafka:
3737
name: Quest Smoke and Load Tests for Standalone deployments with Kafka
3838
runs-on: ubuntu-latest
3939
steps:
4040
- name: Checkout
41-
uses: actions/checkout@v3
41+
uses: actions/checkout@v4
4242
- name: Start compose
4343
run: docker compose -f docker-compose-test-with-kafka.yaml up --build --exit-code-from quest
4444
- name: Stop compose
4545
if: always()
46-
run: docker compose -f docker-compose-test-with-kafka.yaml down
46+
run: docker compose -f docker-compose-test-with-kafka.yaml down -v
4747

4848
docker-compose-distributed-test-with-kafka:
4949
name: Quest Smoke and Load Tests for Distributed deployments with Kafka
5050
runs-on: ubuntu-latest
5151
steps:
5252
- name: Checkout
53-
uses: actions/checkout@v3
53+
uses: actions/checkout@v4
5454
- name: Start compose
5555
run: docker compose -f docker-compose-distributed-test-with-kafka.yaml up --build --exit-code-from quest
5656
- name: Stop compose
5757
if: always()
58-
run: docker compose -f docker-compose-distributed-test-with-kafka.yaml down
58+
run: docker compose -f docker-compose-distributed-test-with-kafka.yaml down -v

0 commit comments

Comments
 (0)