Skip to content

Asset Conversion LPFee Should Use a Per{Something} Instead of u32 #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
joepetrowski opened this issue Jun 25, 2023 · 0 comments · May be fixed by paritytech/substrate#14823
Open

Asset Conversion LPFee Should Use a Per{Something} Instead of u32 #88

joepetrowski opened this issue Jun 25, 2023 · 0 comments · May be fixed by paritytech/substrate#14823
Assignees
@PatricioNapoli
Labels
I4-refactor Code needs refactoring. T1-FRAME This PR/Issue is related to core FRAME, the framework.

Comments

@joepetrowski
Copy link
Contributor

joepetrowski commented Jun 25, 2023 •
edited
Loading

As noted here, it would be more idiomatic to use a PerThing rather than a u32 for LPFee. This was initially set as a u32 to be similar to Uniswap, but should be migrated to PerThing.
@joepetrowski joepetrowski mentioned this issue Jun 25, 2023
Open
@PatricioNapoli PatricioNapoli linked a pull request Aug 24, 2023 that will close this issue
Open
@joepetrowski joepetrowski transferred this issue from paritytech/substrate Aug 24, 2023
@Acaishiba Acaishiba mentioned this issue Aug 24, 2023
Open
@the-right-joyce the-right-joyce added I4-refactor Code needs refactoring. T1-FRAME This PR/Issue is related to core FRAME, the framework. and removed I7-refactor labels Aug 25, 2023
@PatricioNapoli PatricioNapoli mentioned this issue Aug 29, 2023
Closed
@PatricioNapoli PatricioNapoli self-assigned this Aug 29, 2023
jonathanudd pushed a commit to jonathanudd/polkadot-sdk that referenced this issue Apr 10, 2024
@dependabot-preview @bkchr
Bump linked-hash-map from 0.5.2 to 0.5.3 (paritytech#88)
5a463ff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PatricioNapoli PatricioNapoli

Labels
I4-refactor Code needs refactoring. T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
Runtime / FRAME
Status: Backlog
Milestone
No milestone
3 participants
@joepetrowski @PatricioNapoli @the-right-joyce