Skip to content

Add taplo/zepter support to the cmd bot #8078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
2 tasks
bkontur opened this issue Mar 28, 2025 · 4 comments · May be fixed by #8466
Open
2 tasks

Add taplo/zepter support to the cmd bot #8078

bkontur opened this issue Mar 28, 2025 · 4 comments · May be fixed by #8466
Assignees
@AndWeHaveAPlan
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. I5-enhancement An additional feature request.

Comments

@bkontur
Copy link
Contributor

bkontur commented Mar 28, 2025 •
edited
Loading

This could be very useful in cases where we want to push a branch from someone else's fork or without needing to check it out locally and install taplo / zepter.

Original idea:

/cmd taplo

/cmd zepter

or just one command for both

/cmd fix-toml

Additional options:
    --package / -p <module> (multi)

TODO

  • add to the polkadot-sdk bot
  • add to the polkadot-fellows bot
@bkontur bkontur added C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. I5-enhancement An additional feature request. labels Mar 28, 2025
@bkchr
Copy link
Member

bkchr commented Mar 28, 2025

taplo is already part of fmt:

polkadot-sdk/.github/scripts/cmd/cmd.py

Line 265 in 9be43c0

taplo_status = os.system('taplo format --config .config/taplo.toml')

zepter should be added there as well.

@evilrobot-01
Copy link

If useful: tamasfe/taplo#715

@luizhenridev
Copy link

MR CREATED - #8252

@luizhenridev luizhenridev mentioned this issue Apr 16, 2025
Closed
4 tasks
@bkontur
Copy link
Contributor Author

bkontur commented Apr 16, 2025 •
edited
Loading

MR CREATED - #8252

@luizhenridev thank you for your PR, but as Basti said above, it should be enough to add zepter as a part of fmt bot command and not to add new dedicated command

@bkontur bkontur linked a pull request May 8, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndWeHaveAPlan AndWeHaveAPlan

Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. I5-enhancement An additional feature request.
Projects
@bkontur's board
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[CI] Fmt bot: add Taplo and Zepter AbuTuraab/polkadot-sdk
5 participants
@bkchr @AndWeHaveAPlan @bkontur @evilrobot-01 @luizhenridev