Skip to content

Commit f627a42

Browse files
authored
ethereum-types: fix wasm builds for serialize feature (#503)
* ethbloom: do not pull std for 'serialize' feature * ethereum-types: do not pull std for 'serialize' feature * CI: check wasm builds for ethbloom and ethereum-types * fix wasm target * CI: remove redundant check * CI: fix wasm target install * update changelogs
1 parent 1d3de9e commit f627a42

File tree

5 files changed

+8
-2
lines changed

5 files changed

+8
-2
lines changed

.travis.yml

+2
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ matrix:
2727
allow_failures:
2828
- rust: nightly
2929
install:
30+
- rustup target add wasm32-unknown-unknown
3031
- curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.35.3/install.sh | sh
3132
- source ~/.nvm/nvm.sh
3233
- nvm install --lts
@@ -43,6 +44,7 @@ script:
4344
cd contract-address/ && cargo test --features=external_doc && cd ..;
4445
fi
4546
- cd ethbloom/ && cargo test --no-default-features --features="rustc-hex" && cargo check --benches && cd ..
47+
- cd ethereum-types/ && cargo build --no-default-features --features="serialize,rlp" --target=wasm32-unknown-unknown && cd ..
4648
- cd fixed-hash/ && cargo test --all-features && cargo test --no-default-features --features="byteorder,rustc-hex" && cd ..
4749
- cd uint/ && cargo test --all-features && cargo test --no-default-features && cd ..
4850
- cd keccak-hash/ && cargo test --no-default-features && cd ..

ethbloom/CHANGELOG.md

+2
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ The format is based on [Keep a Changelog].
55
[Keep a Changelog]: http://keepachangelog.com/en/1.0.0/
66

77
## [Unreleased]
8+
### Potentially-breaking
9+
- `serialize` feature no longer pulls `std`. [#503](https://github.com/paritytech/parity-common/pull/503)
810

911
## [0.10.0] - 2021-01-05
1012
### Breaking

ethbloom/Cargo.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ hex-literal = "0.3.1"
2525
[features]
2626
default = ["std", "rlp", "serialize", "rustc-hex"]
2727
std = ["fixed-hash/std", "crunchy/std"]
28-
serialize = ["std", "impl-serde"]
28+
serialize = ["impl-serde"]
2929
rustc-hex = ["fixed-hash/rustc-hex"]
3030
arbitrary = ["fixed-hash/arbitrary"]
3131
rlp = ["impl-rlp"]

ethereum-types/CHANGELOG.md

+2
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ The format is based on [Keep a Changelog].
55
[Keep a Changelog]: http://keepachangelog.com/en/1.0.0/
66

77
## [Unreleased]
8+
### Potentially-breaking
9+
- `serialize` feature no longer pulls `std`. [#503](https://github.com/paritytech/parity-common/pull/503)
810

911
## [0.10.0] - 2021-01-05
1012
### Breaking

ethereum-types/Cargo.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ serde_json = "1.0.41"
2222
[features]
2323
default = ["std", "rlp", "serialize"]
2424
std = ["uint-crate/std", "fixed-hash/std", "ethbloom/std", "primitive-types/std"]
25-
serialize = ["std", "impl-serde", "primitive-types/serde", "ethbloom/serialize"]
25+
serialize = ["impl-serde", "primitive-types/serde_no_std", "ethbloom/serialize"]
2626
arbitrary = ["ethbloom/arbitrary", "fixed-hash/arbitrary", "uint-crate/arbitrary"]
2727
rlp = ["impl-rlp", "ethbloom/rlp", "primitive-types/rlp"]
2828
codec = ["impl-codec", "ethbloom/codec"]

0 commit comments

Comments
 (0)