Skip to content

Resource leak: HTTP response bodies not closed on redirects #6182

@jaffarkeikei

Description

@jaffarkeikei

Location: pkg/debuginfo/debuginfod.go:401-413

When handleResponse follows redirects, old response bodies aren't closed before making new requests:

case 3:
    resp, err = c.doRequest(ctx, resp.Header.Get("Location"))  // ❌ Old resp.Body leaked
    if err != nil {
        return nil, fmt.Errorf("request failed: %w", err)
    }
    continue

Fix:

case 3:
    redirectURL := resp.Header.Get("Location")
    resp.Body.Close()  // ✅ Close before redirect
    resp, err = c.doRequest(ctx, redirectURL)
    if err != nil {
        return nil, fmt.Errorf("request failed: %w", err)
    }
    continue

Impact: Leaks file descriptors and memory when debuginfod servers return redirects.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions