Reconnect on connection lost?

[tesla-srt]

So I have this code where it will always create a new connection to the server.
But obviously this is creating a new connection over and over again.

I'm wondering how I can make this more efficient.

 {
    "uid": "1337hxd",
    "type": "request/response",
    "msg": "test"
 }

$sp = websocket_open($server, 8443,'',$errstr, 10,false);
while(true) {
    if ($sp) {
        $msg = websocket_read($sp, $errstr);
        //echo $errstr;
        //websocket_write($sp,$message);
        $msg = json_decode($msg, true);
        if ($msg["uid"] == $uid && $msg["type"] == "request") {
            $cmd = strtolower($msg["msg"]);
            switch ($cmd) {
                case "test":
                    echo "success!\n\n";
                    $buffer = array(
                        'uid' => $uid,
                        'type' => 'response',
                        'msg' => 'Success'
                    );
                    websocket_write($sp, json_encode($buffer));
                    break;
            }
        }
    } else {
        echo "Reconnecting!";
        while(!$sp) {
            $sp = websocket_open($server, 8443,'',$errstr, 10,false);
        }
        echo "Connecting to server: $server \n";
    }
}

This code doesn't work as intended unless the initialization of $sp is within the while loop. but then we get the problem of thousands of new connections.

[paragi]

You should check that $sp is not false, before you enter the while loop.

I don't think that the resource ($sp) will ever change to false. Even if the connection is lost.
The only situation where $sp == false, is if it doesn't succeed in establishing a connection.

You should instead check if the write operation succeed.

websocket_write(..) === false

If it fails, you should re-initiate the connection, by closing and opening the connection.

Please let me know if this helps?

[tesla-srt]

Thank you, thank you. I rewrote the code to test if my application can write a heartbeat to the server.
It does this now at the top of the loop and then continues based on the result :)

[tesla-srt]

This is the updated code. Again, thank you so much!

$s = false;
$sp = true;
while(!$s) {
    echo "Connecting to server: $server \n";
    $sp = websocket_open($server, 8443,'',$errstr, 10,false);
    $s = websocket_write($sp, "123");
    if ($s) {echo "connected!";}
}
while(true) {
    $buffer = array(
        'uid' => $uid,
        'type' => 'heartbeat',
        'msg' => 'success'
    );
    $s = websocket_write($sp, json_encode($buffer));
    if ($s) {
        $msg = websocket_read($sp, $errstr);
        //echo $errstr;
        //websocket_write($sp,$message);
        $msg = json_decode($msg, true);
        if ($msg["uid"] == $uid && $msg["type"] == "request") {
            $cmd = strtolower($msg["msg"]);
            switch ($cmd) {
                case "test":
                    echo "success!\n\n";
                    $buffer = array(
                        'uid' => $uid,
                        'type' => 'response',
                        'msg' => 'Success'
                    );
                    $s = websocket_write($sp, json_encode($buffer));
                    break;
        }
    } else {
        echo "Reconnecting!";
        while(!$s) {
            $sp = websocket_open($server, 8443,'',$errstr, 10,false);
            $s = websocket_write($sp, "123");
        }
        echo "Connecting to server: $server \n";
    }
}

[paragi]

Glad I could help - You are welcome :)