Allow switching away from spaces with no windows

Now that we can switch from a window to an empty space, it's awkward if
we can't switch from an empty space back to a window.

We need to change the KeybindingFlags because when you set PER_WINDOW,
gnome-shell doesn't activate the keybinding unless a window is selected.

Author: smichel17

keybindings.js

@@ -222,10 +222,38 @@ export function setupActions(settings) {
     registerMinimapAction("switch-eleventh", (mw, space) => Tiling.activateNthWindow(10, space));
     registerMinimapAction("switch-last", Tiling.activateLastWindow);
 
-    registerMinimapAction("switch-global-right", (mw, space) => space.switchGlobalRight());
-    registerMinimapAction("switch-global-left", (mw, space) => space.switchGlobalLeft());
-    registerMinimapAction("switch-global-up", (mw, space) => space.switchGlobalUp());
-    registerMinimapAction("switch-global-down", (mw, space) => space.switchGlobalDown());
+    registerAction("switch-global-right", (_mw, space) => {
+        space.switchGlobalRight()
+    }, {
+        settings: keybindSettings,
+        opensNavigator: true,
+        opensMinimap: true,
+        mutterFlags: Meta.KeyBindingFlags.NONE,
+    });
+    registerAction("switch-global-left", (_mw, space) => {
+        space.switchGlobalLeft()
+    }, {
+        settings: keybindSettings,
+        opensNavigator: true,
+        opensMinimap: true,
+        mutterFlags: Meta.KeyBindingFlags.NONE,
+    });
+    registerAction("switch-global-up", (_mw, space) => {
+        space.switchGlobalUp()
+    }, {
+        settings: keybindSettings,
+        opensNavigator: true,
+        opensMinimap: true,
+        mutterFlags: Meta.KeyBindingFlags.NONE,
+    });
+    registerAction("switch-global-down", (_mw, space) => {
+        space.switchGlobalDown()
+    }, {
+        settings: keybindSettings,
+        opensNavigator: true,
+        opensMinimap: true,
+        mutterFlags: Meta.KeyBindingFlags.NONE,
+    });
 
     registerMinimapAction("move-left",
         (_mw, space) => space.swap(Meta.MotionDirection.LEFT));

tiling.js

@@ -1197,22 +1197,9 @@ export class Space extends Array {
             [Meta.MotionDirection.DOWN]: Meta.DisplayDirection.DOWN,
         };
         const dir = motionToDisplayDirection[direction]
-
         let space = this;
-        let index = space.selectedIndex();
-        if (index === -1) {
-            return;
-        }
-        let row = space[index].indexOf(space.selectedWindow);
 
-        switch (direction) {
-        case Meta.MotionDirection.RIGHT:
-            index++;
-            break;
-        case Meta.MotionDirection.LEFT:
-            index--;
-        }
-        if (index < 0 || index >= space.length) {
+        const switchMonitor = () => {
             const monitor = focusMonitor();
             const i = display.get_monitor_neighbor_index(monitor.index, dir);
             if (i === -1) {
@@ -1221,7 +1208,9 @@ export class Space extends Array {
 
             // Ensure if we change workspaces and then monitors,
             // that the new workspace stays active on the starting monitor.
-            space.activateWithFocus(space.selectedWindow, false, true);
+            if (space.selectedWindow) {
+                space.activateWithFocus(space.selectedWindow, false, true);
+            }
 
             const newMonitor = Main.layoutManager.monitors[i];
             const newSpace = spaces.monitors.get(newMonitor);
@@ -1247,7 +1236,25 @@ export class Space extends Array {
             const newWindow = sortWindows(newSpace, newColumn)[newColumn.length - 1];
 
             ensureViewport(newWindow, newSpace);
-            return
+        };
+
+        let index = space.selectedIndex();
+        if (index === -1) {
+            switchMonitor();
+            return;
+        }
+        let row = space[index].indexOf(space.selectedWindow);
+
+        switch (direction) {
+        case Meta.MotionDirection.RIGHT:
+            index++;
+            break;
+        case Meta.MotionDirection.LEFT:
+            index--;
+        }
+        if (index < 0 || index >= space.length) {
+            switchMonitor();
+            return;
         }
 
         let column = space[index];