Fix all clippy warnings — CI should pass now

- Collapse nested if-let blocks (collapsible_if)
- Use std::slice::from_ref instead of clone-to-slice
- Add type alias for complex browser function type
- Suppress dead_code for deserialization-only fields

Author: longevityboris

src/api/mod.rs

@@ -70,10 +70,10 @@ impl SunoClient {
 
     fn headers(&self) -> reqwest::header::HeaderMap {
         let mut headers = reqwest::header::HeaderMap::new();
-        if let Ok(jwt) = self.auth.jwt() {
-            if let Ok(val) = format!("Bearer {jwt}").parse() {
-                headers.insert("authorization", val);
-            }
+        if let Ok(jwt) = self.auth.jwt()
+            && let Ok(val) = format!("Bearer {jwt}").parse()
+        {
+            headers.insert("authorization", val);
         }
         if let Ok(val) = self.auth.device_id().parse() {
             headers.insert("device-id", val);

src/api/persona.rs

@@ -14,18 +14,17 @@ impl SunoClient {
             .await?;
         let resp = self.check_response(resp).await?;
 
-        // The response may be the persona directly or wrapped in a paginated envelope.
-        // Try direct parse first, fall back to extracting from items array.
         let body: serde_json::Value = resp.json().await?;
 
-        if let Some(items) = body.get("items").and_then(|v| v.as_array()) {
-            if let Some(first) = items.first() {
-                let info: PersonaInfo = serde_json::from_value(first.clone())?;
-                return Ok(info);
-            }
+        if let Some(first) = body
+            .get("items")
+            .and_then(|v| v.as_array())
+            .and_then(|items| items.first())
+        {
+            let info: PersonaInfo = serde_json::from_value(first.clone())?;
+            return Ok(info);
         }
 
-        // Try parsing the entire response as PersonaInfo
         let info: PersonaInfo = serde_json::from_value(body)?;
         Ok(info)
     }

src/api/types.rs

@@ -103,8 +103,10 @@ pub struct ClipMetadata {
 pub struct FeedResponse {
     #[serde(default)]
     pub clips: Vec<Clip>,
+    #[allow(dead_code)]
     pub next_cursor: Option<String>,
     #[serde(default)]
+    #[allow(dead_code)]
     pub has_more: bool,
 }
 
@@ -196,6 +198,7 @@ pub struct ControlSliders {
 pub struct GenerateResponse {
     #[serde(default)]
     pub clips: Vec<Clip>,
+    #[allow(dead_code)]
     pub status: Option<String>,
 }
 
@@ -232,6 +235,7 @@ pub struct AlignedWord {
 
 // --- Captcha Check ---
 
+#[allow(dead_code)]
 #[derive(Debug, Deserialize)]
 pub struct CaptchaCheckResponse {
     #[serde(default)]
@@ -272,6 +276,7 @@ pub struct ConcatRequest {
 
 // --- Persona ---
 
+#[allow(dead_code)]
 #[derive(Debug, Deserialize, Serialize)]
 pub struct PersonaResponse {
     #[serde(default)]

src/auth.rs

@@ -107,7 +107,8 @@ pub fn extract_clerk_cookie() -> Result<String, CliError> {
     let domains = Some(vec!["auth.suno.com".to_string(), ".suno.com".to_string()]);
 
     // Each closure calls a different browser extractor
-    let browsers: &[(&str, &dyn Fn() -> eyre::Result<Vec<rookie::enums::Cookie>>)] = &[
+    type BrowserFn = dyn Fn() -> eyre::Result<Vec<rookie::enums::Cookie>>;
+    let browsers: &[(&str, &BrowserFn)] = &[
         ("Chrome", &|| {
             rookie::chrome(Some(vec!["auth.suno.com".into(), ".suno.com".into()]))
         }),

src/cli.rs

@@ -485,6 +485,7 @@ pub enum VariationCategory {
 }
 
 impl VariationCategory {
+    #[allow(dead_code)]
     pub fn to_api_value(&self) -> &'static str {
         match self {
             Self::High => "high",

src/main.rs

@@ -228,15 +228,14 @@ async fn run() -> Result<(), CliError> {
             let c = client().await?;
 
             // Check captcha before generating
-            if let Ok(captcha_needed) = c.check_captcha().await {
-                if captcha_needed && args.token.is_none() {
-                    eprintln!(
-                        "Warning: captcha required. Use --token <hcaptcha_token> or solve captcha in browser."
-                    );
-                    eprintln!(
-                        "Tip: Premier accounts with 200+ credits consumed usually skip captcha."
-                    );
-                }
+            if let Ok(captcha_needed) = c.check_captcha().await
+                && captcha_needed
+                && args.token.is_none()
+            {
+                eprintln!(
+                    "Warning: captcha required. Use --token <hcaptcha_token> or solve captcha in browser."
+                );
+                eprintln!("Tip: Premier accounts with 200+ credits consumed usually skip captcha.");
             }
 
             // If persona specified, use task="vox"
@@ -408,7 +407,10 @@ async fn run() -> Result<(), CliError> {
         }
 
         Commands::Info(args) => {
-            let clips = client().await?.get_clips(&[args.id.clone()]).await?;
+            let clips = client()
+                .await?
+                .get_clips(std::slice::from_ref(&args.id))
+                .await?;
             if clips.is_empty() {
                 return Err(CliError::NotFound(format!("clip: {}", args.id)));
             }