Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use _analogRead() rather than analogRead() in getBatteryVolts() #2

Open
michaelherger opened this issue May 15, 2021 · 0 comments
Open

Use _analogRead() rather than analogRead() in getBatteryVolts() #2

michaelherger opened this issue May 15, 2021 · 0 comments

Comments

@michaelherger
Copy link

18650CL/src/Pangodream_18650_CL.cpp

Line 152 in e1be2aa

int readValue = analogRead(_addressPin);

You should use your own, internal _analogRead() function to respect the number of read iterations.
michaelherger added a commit to michaelherger/18650CL that referenced this issue May 15, 2021
@michaelherger
Fix pangodream#2 use _analogRead() rather than analogRead() to ge…
834f342 
…t the averaged value of multiple reads
michaelherger added a commit to michaelherger/18650CL that referenced this issue May 15, 2021
@michaelherger
Fix pangodream#2 use _analogRead() rather than analogRead() to ge…
73dea61 
…t the averaged value of multiple reads
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michaelherger