Skip to content

Run serialization tests with jackson 2.9.5 #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
iamdanfox opened this issue Jun 5, 2018 · 1 comment
Closed

Run serialization tests with jackson 2.9.5 #13

iamdanfox opened this issue Jun 5, 2018 · 1 comment

Comments

@iamdanfox
Copy link
Contributor

iamdanfox commented Jun 5, 2018 •
edited
Loading

An internal product has reported conjure-related serialization tests failing when they updated jackson to 2.9.5 (via http-remoting: palantir/conjure-java-runtime#713)

We could run tests against the same version instead of the current 2.7.4.
@dansanduleac dansanduleac mentioned this issue Jun 22, 2018
Closed
1 task
@iamdanfox iamdanfox reopened this Jul 7, 2018
@iamdanfox
Copy link
Contributor Author

Fixed here: https://github.com/palantir/conjure-java/pull/36/files#diff-5cc9a44dfecc8497136473bfe79c14f9R1

carterkozak pushed a commit to carterkozak/conjure-java that referenced this issue Dec 24, 2018
@dansanduleac @iamdanfox
Generalize generator task (palantir#13)
e86d9e4 
* Generalize a ConjureGeneratorTask

* GeneratorOptions copy constructor

* Stop using `setGenerateTask` and just copy GeneratorOptions

* and get rid of CompileConjurePythonTask

* and CompileConjureJavaTask too

* shouldn't be abstract

* need to copy!!

* TaskAction weird behaviour
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iamdanfox