Bytes has signed and unsigned comparators

Author: schlosna

conjure-lib/build.gradle

@@ -26,6 +26,7 @@ dependencies {
 
     implementation 'com.fasterxml.jackson.core:jackson-annotations'
     implementation 'com.fasterxml.jackson.core:jackson-core'
+    implementation 'com.google.guava:guava'
     implementation 'com.palantir.safe-logging:safe-logging'
 
     testImplementation 'com.palantir.safe-logging:preconditions-assertj'

conjure-lib/src/main/java/com/palantir/conjure/java/lib/Bytes.java

@@ -24,11 +24,15 @@
 import com.fasterxml.jackson.databind.SerializerProvider;
 import com.fasterxml.jackson.databind.annotation.JsonDeserialize;
 import com.fasterxml.jackson.databind.annotation.JsonSerialize;
+import com.google.common.primitives.SignedBytes;
+import com.google.common.primitives.UnsignedBytes;
 import java.io.ByteArrayInputStream;
 import java.io.IOException;
 import java.io.InputStream;
 import java.nio.ByteBuffer;
 import java.util.Arrays;
+import java.util.Comparator;
+import org.jetbrains.annotations.NotNull;
 
 /** An immutable {@code byte[]} wrapper. */
 @JsonSerialize(using = Bytes.Serializer.class)
@@ -85,6 +89,14 @@ public boolean equals(Object obj) {
         return this == obj || (obj instanceof Bytes && Arrays.equals(safe, ((Bytes) obj).safe));
     }
 
+    public Comparator<Bytes> signed() {
+        return (x, y) -> SignedBytes.lexicographicalComparator().compare(x.safe, y.safe);
+    }
+
+    public Comparator<Bytes> unsigned() {
+        return (x, y) -> UnsignedBytes.lexicographicalComparator().compare(x.safe, y.safe);
+    }
+
     @Override
     public String toString() {
         return "Bytes{size: " + safe.length + '}';