Correct comment & add tests

Author: ollie299792458

packages/core/src/components/hotkeys/hotkeyParser.ts

@@ -63,11 +63,9 @@ export const CONFIG_ALIASES: KeyMap = {
 };
 
 /**
- * Key mapping used in getKeyCombo() implementation for physical keys which are not alphabet characters or digits.
- *
- * N.B. at some point, we should stop using this mapping, since we can implement the desired functionality in a more
- * straightforward way by using the `event.code` property, which will always tell us the identifiers represented by the
- * _values_ in this object (the default physical keys, unaltered by modifier keys or keyboard layout).
+ * Key mapping used in getKeyCombo() implementation to normalize shifted character keys.
+ * Maps shifted characters (e.g., "!") to their unshifted equivalents (e.g., "1") so that
+ * "!" and "shift+1" are treated as the same hotkey combo.
  */
 export const SHIFT_KEYS: KeyMap = {
     "~": "`",

packages/core/test/hotkeys/hotkeysParserTests.ts

@@ -137,6 +137,13 @@ describe("HotkeysParser", () => {
             tests.push(makeComboTest("alt + a", { altKey: true, code: "KeyA", key: "a" }));
             verifyCombos(tests);
         });
+
+        it("handles alt modifier with special characters (macOS)", () => {
+            // On macOS, Alt+C produces "ç" - we should fall back to code-based matching
+            const tests = [] as ComboTest[];
+            tests.push(makeComboTest("alt + c", { altKey: true, code: "KeyC", key: "ç" }));
+            verifyCombos(tests, false); // don't verify string combos since key is "ç" not "c"
+        });
     });
 
     describe("parseKeyCombo", () => {