Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill Count category - Add existing PB to posted result #645

Open
2 tasks done
bergjerg opened this issue Jan 28, 2025 · 2 comments · May be fixed by #648
Open
2 tasks done

Kill Count category - Add existing PB to posted result #645

bergjerg opened this issue Jan 28, 2025 · 2 comments · May be fixed by #648
Assignees
Labels
enhancement Improvement to an already existing notifier Notifier: Kill Count

Comments

@bergjerg
Copy link

Checklist

  • I've searched the issues and pull requests for similar looking suggestions.
  • I've checked the Unreleased section of the changelog for newly added features that sound like my suggestion.

Describe your Suggestion

The Kill Count category has an option to send personal best messages when a PB occurs. It also has an option to send the duration of each kill as it happens using the %TIME% keyword. I propose including the option to send existing PBs for kills where a PB does not happen.

This option exists in the Quest Speedrunning category already by including the %BEST% keyword in the notification message box. A similar option in the notification area of the Kill Count category, or including as it's own field in the extra json would be great.

Image

Reasoning

I am building a hiscores for boss PBs in my clan. So far it's been done with the chat logger picking up clan broadcast PB messages through dink (Thanks!). Some people have quick times they would like to see posted but don't want to go back for a faster kill so allowing dink to send existing PBs would let me include those.

I could try to achieve this through more chat filtering and associating a KC (Boss Name) message with the followup PB message server side, but I figure as the plugin already has the association of an existing PB message to a boss name it may be a little more straight forward to make the change here.

@bergjerg bergjerg added the enhancement Improvement to an already existing notifier label Jan 28, 2025
@iProdigy iProdigy self-assigned this Jan 30, 2025
@iProdigy
Copy link
Member

note: for certain bosses, jagex reports the duration but not the pb time - but otherwise the PR should support your use case

i'll look into piggybacking off stored data from runelite's chat commands plugin to fill in missing pb data as needed

@bergjerg
Copy link
Author

Absolute legend, thank you for including this.

Piggybacking on the chat commands plugin would be a big improvement for what I'm trying to do so again thanks for checking.

With my use case - We have about 20% of the clan using DINK to monitor all clan PB broadcasts (Understandably not everyone wants to insall plugins that connect to 3rd party sources). So by picking up on !pb messages via clan chat it would let us capture those existing PBs for the other 80% too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to an already existing notifier Notifier: Kill Count
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants